diff --git a/Kernel/Devices/GPU/3dfx/GraphicsAdapter.cpp b/Kernel/Devices/GPU/3dfx/GraphicsAdapter.cpp index 4a5f665ac41..9d5d3ca9d44 100644 --- a/Kernel/Devices/GPU/3dfx/GraphicsAdapter.cpp +++ b/Kernel/Devices/GPU/3dfx/GraphicsAdapter.cpp @@ -34,7 +34,7 @@ UNMAP_AFTER_INIT ErrorOr VoodooGraphicsAdapter::probe(PCI::DeviceIdentifie return id.vendor_id == PCI::VendorID::Tdfx && is_supported_model(id.device_id); } -UNMAP_AFTER_INIT ErrorOr> VoodooGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) +UNMAP_AFTER_INIT ErrorOr> VoodooGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) { auto adapter = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) VoodooGraphicsAdapter(pci_device_identifier))); MUST(adapter->initialize_adapter(pci_device_identifier)); diff --git a/Kernel/Devices/GPU/3dfx/GraphicsAdapter.h b/Kernel/Devices/GPU/3dfx/GraphicsAdapter.h index af70abfb89d..d6d319574eb 100644 --- a/Kernel/Devices/GPU/3dfx/GraphicsAdapter.h +++ b/Kernel/Devices/GPU/3dfx/GraphicsAdapter.h @@ -9,16 +9,16 @@ #include #include #include -#include +#include namespace Kernel { -class VoodooGraphicsAdapter final : public GenericGraphicsAdapter +class VoodooGraphicsAdapter final : public GPUDevice , public PCI::Device { public: static ErrorOr probe(PCI::DeviceIdentifier const&); - static ErrorOr> create(PCI::DeviceIdentifier const&); + static ErrorOr> create(PCI::DeviceIdentifier const&); virtual ~VoodooGraphicsAdapter() = default; virtual StringView device_name() const override { return "VoodooGraphicsAdapter"sv; } diff --git a/Kernel/Devices/GPU/Bochs/GraphicsAdapter.cpp b/Kernel/Devices/GPU/Bochs/GraphicsAdapter.cpp index addde186c36..ab3fb118a3a 100644 --- a/Kernel/Devices/GPU/Bochs/GraphicsAdapter.cpp +++ b/Kernel/Devices/GPU/Bochs/GraphicsAdapter.cpp @@ -33,7 +33,7 @@ UNMAP_AFTER_INIT ErrorOr BochsGraphicsAdapter::probe(PCI::DeviceIdentifier return false; } -UNMAP_AFTER_INIT ErrorOr> BochsGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) +UNMAP_AFTER_INIT ErrorOr> BochsGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) { auto adapter = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) BochsGraphicsAdapter(pci_device_identifier))); MUST(adapter->initialize_adapter(pci_device_identifier)); diff --git a/Kernel/Devices/GPU/Bochs/GraphicsAdapter.h b/Kernel/Devices/GPU/Bochs/GraphicsAdapter.h index 728308c693d..4929bb0489e 100644 --- a/Kernel/Devices/GPU/Bochs/GraphicsAdapter.h +++ b/Kernel/Devices/GPU/Bochs/GraphicsAdapter.h @@ -10,7 +10,7 @@ #include #include #include -#include +#include #include #include @@ -19,13 +19,13 @@ namespace Kernel { class GraphicsManagement; struct BochsDisplayMMIORegisters; -class BochsGraphicsAdapter final : public GenericGraphicsAdapter +class BochsGraphicsAdapter final : public GPUDevice , public PCI::Device { friend class GraphicsManagement; public: static ErrorOr probe(PCI::DeviceIdentifier const&); - static ErrorOr> create(PCI::DeviceIdentifier const&); + static ErrorOr> create(PCI::DeviceIdentifier const&); virtual ~BochsGraphicsAdapter() = default; virtual StringView device_name() const override { return "BochsGraphicsAdapter"sv; } diff --git a/Kernel/Devices/GPU/Console/Console.h b/Kernel/Devices/GPU/Console/Console.h index 9b036d32e5f..5d4dee47606 100644 --- a/Kernel/Devices/GPU/Console/Console.h +++ b/Kernel/Devices/GPU/Console/Console.h @@ -8,7 +8,7 @@ #include #include -#include +#include namespace Kernel::Graphics { diff --git a/Kernel/Devices/GPU/GenericGraphicsAdapter.h b/Kernel/Devices/GPU/GPUDevice.h similarity index 61% rename from Kernel/Devices/GPU/GenericGraphicsAdapter.h rename to Kernel/Devices/GPU/GPUDevice.h index 802b7cac80b..32e12c3ae35 100644 --- a/Kernel/Devices/GPU/GenericGraphicsAdapter.h +++ b/Kernel/Devices/GPU/GPUDevice.h @@ -13,14 +13,14 @@ #include namespace Kernel { -class GenericGraphicsAdapter - : public AtomicRefCounted - , public LockWeakable { +class GPUDevice + : public AtomicRefCounted + , public LockWeakable { public: - virtual ~GenericGraphicsAdapter() = default; + virtual ~GPUDevice() = default; protected: - GenericGraphicsAdapter() = default; + GPUDevice() = default; }; } diff --git a/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.cpp b/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.cpp index cc61f2294a4..e11e96e78d3 100644 --- a/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.cpp +++ b/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.cpp @@ -32,7 +32,7 @@ ErrorOr IntelNativeGraphicsAdapter::probe(PCI::DeviceIdentifier const& pci return is_supported_model(pci_device_identifier.hardware_id().device_id); } -ErrorOr> IntelNativeGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) +ErrorOr> IntelNativeGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) { auto adapter = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) IntelNativeGraphicsAdapter(pci_device_identifier))); TRY(adapter->initialize_adapter()); @@ -67,7 +67,7 @@ ErrorOr IntelNativeGraphicsAdapter::initialize_adapter() } IntelNativeGraphicsAdapter::IntelNativeGraphicsAdapter(PCI::DeviceIdentifier const& pci_device_identifier) - : GenericGraphicsAdapter() + : GPUDevice() , PCI::Device(const_cast(pci_device_identifier)) { } diff --git a/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.h b/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.h index 69875d958b4..8d849e859a5 100644 --- a/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.h +++ b/Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.h @@ -17,12 +17,12 @@ namespace Kernel { class IntelNativeGraphicsAdapter final - : public GenericGraphicsAdapter + : public GPUDevice , public PCI::Device { public: static ErrorOr probe(PCI::DeviceIdentifier const&); - static ErrorOr> create(PCI::DeviceIdentifier const&); + static ErrorOr> create(PCI::DeviceIdentifier const&); virtual ~IntelNativeGraphicsAdapter() = default; diff --git a/Kernel/Devices/GPU/Management.cpp b/Kernel/Devices/GPU/Management.cpp index 74f69565007..7e58121b296 100644 --- a/Kernel/Devices/GPU/Management.cpp +++ b/Kernel/Devices/GPU/Management.cpp @@ -123,7 +123,7 @@ static inline bool is_display_controller_pci_device(PCI::DeviceIdentifier const& struct PCIGraphicsDriverInitializer { ErrorOr (*probe)(PCI::DeviceIdentifier const&) = nullptr; - ErrorOr> (*create)(PCI::DeviceIdentifier const&) = nullptr; + ErrorOr> (*create)(PCI::DeviceIdentifier const&) = nullptr; }; static constexpr PCIGraphicsDriverInitializer s_initializers[] = { diff --git a/Kernel/Devices/GPU/Management.h b/Kernel/Devices/GPU/Management.h index 7a832bdb827..cbbfd81572a 100644 --- a/Kernel/Devices/GPU/Management.h +++ b/Kernel/Devices/GPU/Management.h @@ -15,8 +15,8 @@ #include #include #include +#include #include -#include #include #include #include @@ -53,7 +53,7 @@ private: void initialize_preset_resolution_generic_display_connector(); - Vector> m_graphics_devices; + Vector> m_graphics_devices; LockRefPtr m_console; // Note: This is only used when booting with kernel commandline that includes "graphics_subsystem_mode=limited" diff --git a/Kernel/Devices/GPU/VMWare/GraphicsAdapter.cpp b/Kernel/Devices/GPU/VMWare/GraphicsAdapter.cpp index 57b2c72b291..597f4259c0b 100644 --- a/Kernel/Devices/GPU/VMWare/GraphicsAdapter.cpp +++ b/Kernel/Devices/GPU/VMWare/GraphicsAdapter.cpp @@ -28,7 +28,7 @@ ErrorOr VMWareGraphicsAdapter::probe(PCI::DeviceIdentifier const& pci_devi return id.vendor_id == PCI::VendorID::VMWare && id.device_id == 0x0405; } -ErrorOr> VMWareGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) +ErrorOr> VMWareGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier) { auto registers_io_window = TRY(IOWindow::create_for_pci_device_bar(pci_device_identifier, PCI::HeaderType0BaseRegister::BAR0)); auto adapter = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) VMWareGraphicsAdapter(pci_device_identifier, move(registers_io_window)))); diff --git a/Kernel/Devices/GPU/VMWare/GraphicsAdapter.h b/Kernel/Devices/GPU/VMWare/GraphicsAdapter.h index 49a36785dc3..6e0f9311c59 100644 --- a/Kernel/Devices/GPU/VMWare/GraphicsAdapter.h +++ b/Kernel/Devices/GPU/VMWare/GraphicsAdapter.h @@ -8,7 +8,7 @@ #include #include -#include +#include #include #include #include @@ -21,13 +21,13 @@ class GraphicsManagement; class VMWareDisplayConnector; class VMWareGraphicsAdapter final - : public GenericGraphicsAdapter + : public GPUDevice , public PCI::Device { friend class GraphicsManagement; public: static ErrorOr probe(PCI::DeviceIdentifier const&); - static ErrorOr> create(PCI::DeviceIdentifier const&); + static ErrorOr> create(PCI::DeviceIdentifier const&); virtual ~VMWareGraphicsAdapter() = default; virtual StringView device_name() const override { return "VMWareGraphicsAdapter"sv; } diff --git a/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.cpp b/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.cpp index e2ec60d9598..ee03c0a02aa 100644 --- a/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.cpp +++ b/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.cpp @@ -28,7 +28,7 @@ ErrorOr VirtIOGraphicsAdapter::probe(PCI::DeviceIdentifier const& device_i return device_identifier.hardware_id().vendor_id == PCI::VendorID::VirtIO; } -ErrorOr> VirtIOGraphicsAdapter::create(PCI::DeviceIdentifier const& device_identifier) +ErrorOr> VirtIOGraphicsAdapter::create(PCI::DeviceIdentifier const& device_identifier) { // Setup memory transfer region auto scratch_space_region = TRY(MM.allocate_contiguous_kernel_region( diff --git a/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.h b/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.h index bfcee9c56ba..1f89e07c97f 100644 --- a/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.h +++ b/Kernel/Devices/GPU/VirtIO/GraphicsAdapter.h @@ -10,7 +10,7 @@ #include #include #include -#include +#include #include namespace Kernel { @@ -31,14 +31,14 @@ namespace Kernel { class VirtIODisplayConnector; class VirtIOGPU3DDevice; class VirtIOGraphicsAdapter final - : public GenericGraphicsAdapter + : public GPUDevice , public VirtIO::Device { friend class VirtIODisplayConnector; friend class VirtIOGPU3DDevice; public: static ErrorOr probe(PCI::DeviceIdentifier const&); - static ErrorOr> create(PCI::DeviceIdentifier const&); + static ErrorOr> create(PCI::DeviceIdentifier const&); virtual ErrorOr initialize_virtio_resources() override;