mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 12:35:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Treat missing arg in Array.prototype.{indexOf,lastIndexOf}() as undefined

Browse source
This commit is contained in:
Linus Groh 2020-05-22 17:34:52 +01:00 • committed by Andreas Kling
parent a3e4dfdf98
commit 6a4280e6e5
Notes: sideshowbarker 2024-07-19 06:14:40 +09:00
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -357,7 +357,7 @@ Value ArrayPrototype::index_of(Interpreter& interpreter)
return {};
i32 array_size = static_cast<i32>(array->elements().size());
if (interpreter.argument_count() == 0 || array_size == 0)
if (array_size == 0)
return Value(-1);
i32 from_index = 0;
@ -411,7 +411,7 @@ Value ArrayPrototype::last_index_of(Interpreter& interpreter)
return {};
i32 array_size = static_cast<i32>(array->elements().size());
if (interpreter.argument_count() == 0 || array_size == 0)
if (array_size == 0)
return Value(-1);
i32 from_index = 0;

2
Libraries/LibJS/Tests/Array.prototype.indexOf.js
View file

@ -20,6 +20,8 @@ try {
assert([].indexOf('serenity') === -1);
assert([].indexOf('serenity', 10) === -1);
assert([].indexOf('serenity', -10) === -1);
assert([].indexOf() === -1);
assert([undefined].indexOf() === 0);
console.log("PASS");
} catch (e) {

3
Libraries/LibJS/Tests/Array.prototype.lastIndexOf.js
View file

@ -15,6 +15,9 @@ try {
assert([].lastIndexOf('hello') === -1);
assert([].lastIndexOf('hello', 10) === -1);
assert([].lastIndexOf('hello', -10) === -1);
assert([].lastIndexOf() === -1);
assert([undefined].lastIndexOf() === 0);
assert([undefined, undefined, undefined].lastIndexOf() === 2);
console.log("PASS");
} catch (e) {