diff --git a/Libraries/LibWeb/HTML/HTMLTrackElement.cpp b/Libraries/LibWeb/HTML/HTMLTrackElement.cpp index 9b484d5c82b..1c27155b864 100644 --- a/Libraries/LibWeb/HTML/HTMLTrackElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLTrackElement.cpp @@ -180,6 +180,13 @@ void HTMLTrackElement::start_the_track_processing_model_parallel_steps(JS::Realm // 9. End the synchronous section, continuing the remaining steps in parallel. + auto fire_error_event = [&]() { + queue_an_element_task(Task::Source::DOMManipulation, [this, &realm]() { + m_track->set_readiness_state(TextTrack::ReadinessState::FailedToLoad); + dispatch_event(DOM::Event::create(realm, HTML::EventNames::error)); + }); + }; + // 10. If URL is not the empty string, then: if (!url.is_empty()) { // 1. Let request be the result of creating a potential-CORS request given URL, "track", and corsAttributeState, @@ -193,17 +200,14 @@ void HTMLTrackElement::start_the_track_processing_model_parallel_steps(JS::Realm request->set_initiator_type(Fetch::Infrastructure::Request::InitiatorType::Track); Fetch::Infrastructure::FetchAlgorithms::Input fetch_algorithms_input {}; - fetch_algorithms_input.process_response_consume_body = [this, &realm](auto response, auto body_bytes) { + fetch_algorithms_input.process_response_consume_body = [this, &realm, &fire_error_event](auto response, auto body_bytes) { m_loading = false; // If fetching fails for any reason (network error, the server returns an error code, CORS fails, etc.), // or if URL is the empty string, then queue an element task on the DOM manipulation task source given the media element // to first change the text track readiness state to failed to load and then fire an event named error at the track element. if (!response->url().has_value() || body_bytes.template has() || body_bytes.template has() || !Fetch::Infrastructure::is_ok_status(response->status()) || response->is_network_error()) { - queue_an_element_task(Task::Source::DOMManipulation, [this, &realm]() { - m_track->set_readiness_state(TextTrack::ReadinessState::FailedToLoad); - dispatch_event(DOM::Event::create(realm, HTML::EventNames::error)); - }); + fire_error_event(); return; } @@ -232,6 +236,9 @@ void HTMLTrackElement::start_the_track_processing_model_parallel_steps(JS::Realm m_fetch_algorithms = Fetch::Infrastructure::FetchAlgorithms::create(vm(), move(fetch_algorithms_input)); m_fetch_controller = MUST(Fetch::Fetching::fetch(realm, request, *m_fetch_algorithms)); return; + } else { + fire_error_event(); + return; } // 11. Wait until the text track readiness state is no longer set to loading. diff --git a/Tests/LibWeb/Text/expected/wpt-import/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string.txt b/Tests/LibWeb/Text/expected/wpt-import/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string.txt new file mode 100644 index 00000000000..1d477a7f161 --- /dev/null +++ b/Tests/LibWeb/Text/expected/wpt-import/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string.txt @@ -0,0 +1,6 @@ +Harness status: OK + +Found 1 tests + +1 Pass +Pass Setting HTMLTrackElement.src to the empty string fires 'error' and sets readyState to ERROR \ No newline at end of file diff --git a/Tests/LibWeb/Text/input/wpt-import/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string.html b/Tests/LibWeb/Text/input/wpt-import/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string.html new file mode 100644 index 00000000000..1f85568b3d1 --- /dev/null +++ b/Tests/LibWeb/Text/input/wpt-import/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string.html @@ -0,0 +1,21 @@ + +Setting HTMLTrackElement.src to the empty string fires 'error' and sets readyState to ERROR + + + + +