mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-30 06:06:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Use serialize_a_number() for Time serialization

Browse source 
As noted, the spec tells us to do something different than what is
expected by WPT, so we slightly ignore it.
This commit is contained in:
Sam Atkins 2025-08-18 14:10:11 +01:00
commit 6b69b00a05
Notes: github-actions[bot] 2025-08-18 15:53:51 +00:00
1 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Libraries/LibWeb/CSS/Time.cpp
View file

@ -28,9 +28,21 @@ Time Time::percentage_of(Percentage const& percentage) const
String Time::to_string(SerializationMode serialization_mode) const
{
if (serialization_mode == SerializationMode::ResolvedValue)
return MUST(String::formatted("{}s", to_seconds()));
return MUST(String::formatted("{}{}", raw_value(), unit_name()));
// https://drafts.csswg.org/cssom/#serialize-a-css-value
// -> <time>
// The time in seconds serialized as per <number> followed by the literal string "s".
// AD-HOC: WPT expects us to serialize using the actual unit, like for other dimensions.
// https://github.com/w3c/csswg-drafts/issues/12616
if (serialization_mode == SerializationMode::ResolvedValue) {
StringBuilder builder;
serialize_a_number(builder, to_seconds());
builder.append("s"sv);
return builder.to_string_without_validation();
}
StringBuilder builder;
serialize_a_number(builder, raw_value());
builder.append(unit_name());
return builder.to_string_without_validation();
}
double Time::to_seconds() const