From 6bf3d34a6709b5067be0b705ce5a8ed8d4cbfa00 Mon Sep 17 00:00:00 2001 From: sideshowbarker Date: Mon, 9 Sep 2024 20:15:04 +0900 Subject: [PATCH] LibWeb: Add CEReactions to all IDL for all ARIA attributes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change adds the [CEReactions] attributes to all ARIA attributes in the ARIAMixin WebIDL — as required by the WebIDL in the current spec at https://w3c.github.io/aria/#ARIAMixin, and by the WPT test case at http://wpt.live/custom-elements/reactions/AriaMixin-string-attributes.html, and as implemented in other existing engines. Otherwise, without this change, Ladybird doesn’t conform to the current spec, fails all those tests, and isn’t interoperable with other engines. --- Userland/Libraries/LibWeb/ARIA/ARIAMixin.idl | 80 ++++++++++---------- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/Userland/Libraries/LibWeb/ARIA/ARIAMixin.idl b/Userland/Libraries/LibWeb/ARIA/ARIAMixin.idl index b679d0827ac..51078c28881 100644 --- a/Userland/Libraries/LibWeb/ARIA/ARIAMixin.idl +++ b/Userland/Libraries/LibWeb/ARIA/ARIAMixin.idl @@ -1,54 +1,54 @@ -// https://www.w3.org/TR/wai-aria-1.2/#ARIAMixin +// https://w3c.github.io/aria/#ARIAMixin interface mixin ARIAMixin { - attribute DOMString? role; + [CEReactions] attribute DOMString? role; - attribute DOMString? ariaAtomic; - attribute DOMString? ariaAutoComplete; - attribute DOMString? ariaBusy; - attribute DOMString? ariaChecked; - attribute DOMString? ariaColCount; - attribute DOMString? ariaColIndex; + [CEReactions] attribute DOMString? ariaAtomic; + [CEReactions] attribute DOMString? ariaAutoComplete; + [CEReactions] attribute DOMString? ariaBusy; + [CEReactions] attribute DOMString? ariaChecked; + [CEReactions] attribute DOMString? ariaColCount; + [CEReactions] attribute DOMString? ariaColIndex; - attribute DOMString? ariaColSpan; + [CEReactions] attribute DOMString? ariaColSpan; - attribute DOMString? ariaCurrent; + [CEReactions] attribute DOMString? ariaCurrent; - attribute DOMString? ariaDisabled; + [CEReactions] attribute DOMString? ariaDisabled; - attribute DOMString? ariaExpanded; + [CEReactions] attribute DOMString? ariaExpanded; - attribute DOMString? ariaHasPopup; - attribute DOMString? ariaHidden; - attribute DOMString? ariaInvalid; - attribute DOMString? ariaKeyShortcuts; - attribute DOMString? ariaLabel; + [CEReactions] attribute DOMString? ariaHasPopup; + [CEReactions] attribute DOMString? ariaHidden; + [CEReactions] attribute DOMString? ariaInvalid; + [CEReactions] attribute DOMString? ariaKeyShortcuts; + [CEReactions] attribute DOMString? ariaLabel; - attribute DOMString? ariaLevel; - attribute DOMString? ariaLive; - attribute DOMString? ariaModal; - attribute DOMString? ariaMultiLine; - attribute DOMString? ariaMultiSelectable; - attribute DOMString? ariaOrientation; + [CEReactions] attribute DOMString? ariaLevel; + [CEReactions] attribute DOMString? ariaLive; + [CEReactions] attribute DOMString? ariaModal; + [CEReactions] attribute DOMString? ariaMultiLine; + [CEReactions] attribute DOMString? ariaMultiSelectable; + [CEReactions] attribute DOMString? ariaOrientation; - attribute DOMString? ariaPlaceholder; - attribute DOMString? ariaPosInSet; - attribute DOMString? ariaPressed; - attribute DOMString? ariaReadOnly; - attribute DOMString? ariaRelevant; + [CEReactions] attribute DOMString? ariaPlaceholder; + [CEReactions] attribute DOMString? ariaPosInSet; + [CEReactions] attribute DOMString? ariaPressed; + [CEReactions] attribute DOMString? ariaReadOnly; + [CEReactions] attribute DOMString? ariaRelevant; - attribute DOMString? ariaRequired; - attribute DOMString? ariaRoleDescription; - attribute DOMString? ariaRowCount; - attribute DOMString? ariaRowIndex; + [CEReactions] attribute DOMString? ariaRequired; + [CEReactions] attribute DOMString? ariaRoleDescription; + [CEReactions] attribute DOMString? ariaRowCount; + [CEReactions] attribute DOMString? ariaRowIndex; - attribute DOMString? ariaRowSpan; - attribute DOMString? ariaSelected; - attribute DOMString? ariaSetSize; - attribute DOMString? ariaSort; - attribute DOMString? ariaValueMax; - attribute DOMString? ariaValueMin; - attribute DOMString? ariaValueNow; - attribute DOMString? ariaValueText; + [CEReactions] attribute DOMString? ariaRowSpan; + [CEReactions] attribute DOMString? ariaSelected; + [CEReactions] attribute DOMString? ariaSetSize; + [CEReactions] attribute DOMString? ariaSort; + [CEReactions] attribute DOMString? ariaValueMax; + [CEReactions] attribute DOMString? ariaValueMin; + [CEReactions] attribute DOMString? ariaValueNow; + [CEReactions] attribute DOMString? ariaValueText; };