mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/HTML: Add a helper for getting parent <select> for <option>

Browse source
This commit is contained in:
Shannon Booth 2025-01-26 19:13:17 +13:00 • committed by Andrew Kaster
parent 5b6b4d93a3
commit 6c1470994b
Notes: github-actions[bot] 2025-01-30 20:57:00 +00:00
2 changed files with 23 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
Libraries/LibWeb/HTML/HTMLOptionElement.cpp
View file

@ -191,24 +191,32 @@ bool HTMLOptionElement::disabled() const
}
// https://html.spec.whatwg.org/multipage/form-elements.html#dom-option-form
GC::Ptr<HTMLFormElement> HTMLOptionElement::form() const
GC::Ptr<HTMLFormElement const> HTMLOptionElement::form() const
{
// The form IDL attribute's behavior depends on whether the option element is in a select element or not.
// If the option has a select element as its parent, or has an optgroup element as its parent and that optgroup element has a select element as its parent,
// then the form IDL attribute must return the same value as the form IDL attribute on that select element.
// Otherwise, it must return null.
auto const* parent = parent_element();
if (is<HTMLOptGroupElement>(parent))
parent = parent->parent_element();
if (is<HTML::HTMLSelectElement>(parent)) {
auto const* select_element = as<HTMLSelectElement>(parent);
return const_cast<HTMLFormElement*>(select_element->form());
}
if (auto select_element = owner_select_element())
return select_element->form();
return {};
}
GC::Ptr<HTMLSelectElement> HTMLOptionElement::owner_select_element()
{
if (auto* maybe_parent = parent()) {
if (auto* select_element = as_if<HTMLSelectElement>(*maybe_parent))
return select_element;
if (auto* opt_group_element = as_if<HTMLOptGroupElement>(*maybe_parent)) {
if (auto* maybe_parent = opt_group_element->parent())
return as_if<HTMLSelectElement>(*maybe_parent);
}
}
return nullptr;
}
Optional<ARIA::Role> HTMLOptionElement::default_role() const
{
// https://www.w3.org/TR/html-aria/#el-option
@ -226,10 +234,8 @@ void HTMLOptionElement::inserted()
// If insertedNode's parent is a select element,
// or insertedNode's parent is an optgroup element whose parent is a select element,
// then run that select element's selectedness setting algorithm.
if (is<HTMLSelectElement>(*parent()))
static_cast<HTMLSelectElement&>(*parent()).update_selectedness();
else if (is<HTMLOptGroupElement>(parent()) && parent()->parent() && is<HTMLSelectElement>(*parent()->parent()))
static_cast<HTMLSelectElement&>(*parent()->parent()).update_selectedness();
if (auto select_element = owner_select_element())
select_element->update_selectedness();
}
void HTMLOptionElement::removed_from(Node* old_parent, Node& old_root)

5
Libraries/LibWeb/HTML/HTMLOptionElement.h
View file

@ -36,10 +36,13 @@ public:
bool disabled() const;
GC::Ptr<HTML::HTMLFormElement> form() const;
GC::Ptr<HTML::HTMLFormElement const> form() const;
virtual Optional<ARIA::Role> default_role() const override;
GC::Ptr<HTMLSelectElement> owner_select_element();
GC::Ptr<HTMLSelectElement const> owner_select_element() const { return const_cast<HTMLOptionElement&>(*this).owner_select_element(); }
private:
friend class Bindings::OptionConstructor;
friend class HTMLSelectElement;