mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Change where content selection via mouse is allowed

Browse source 
Previously, only DOM nodes with `is_editable()` allowed selection via
the mouse. This had the unwanted consequence, that read-only
input/textarea elements did not allow selection.

Now, `EventHandler::handle_mousedown()` asks the node's non-shadow
parent element over the new virtual method `is_child_node_selectable()`,
if selection of the node is allowed.
This method is overridden for `HTMLButtonElement` and
`HTMLInputElement`, to disallow selection of buttons and placeholders.

Fixes #579
This commit is contained in:
simonkrauter 2024-08-19 17:06:13 -03:00 • committed by Sam Atkins
commit 6c9adf3dbc
Notes: github-actions[bot] 2024-08-23 08:31:56 +00:00
5 changed files with 24 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -204,6 +204,8 @@ public:
WebIDL::ExceptionOr<void> set_selection_end_for_bindings(Optional<WebIDL::UnsignedLong> const&);
Optional<WebIDL::UnsignedLong> selection_end_for_bindings() const;
virtual bool is_child_node_selectable(DOM::Node const&) const override;
private:
HTMLInputElement(DOM::Document&, DOM::QualifiedName);