WebServer: Defer invocation of Client::remove_from_parent()

This is necessary to avoid trying to destruct the on_ready_to_read function from inside the function. This fixes #7810.
Author: https://github.com/MaxWipfli Commit: 6e6ff844d3 Pull-request: https://github.com/SerenityOS/serenity/pull/7879 Reviewed-by: https://github.com/awesomekling Reviewed-by: https://github.com/gunnarbeutner Reviewed-by: https://github.com/linusg Reviewed-by: https://github.com/stelar7
2025-09-12 04:22:28 +00:00 · 2021-06-05 15:50:57 +02:00 · 2021-06-05 15:50:57 +02:00 · 6e6ff844d3 · 2024-07-18 12:26:58 +09:00
commit 6e6ff844d3
parent 5408111aff
1 changed files with 5 additions and 1 deletions
--- a/Userland/Services/WebServer/Client.cpp
+++ b/Userland/Services/WebServer/Client.cpp
@ -1,5 +1,6 @@
 /*
 * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch>
 *
 * SPDX-License-Identifier: BSD-2-Clause
 */
@ -33,7 +34,10 @@ Client::Client(NonnullRefPtr<Core::TCPSocket> socket, String const& root, Core::

 void Client::die()
 {
-    remove_from_parent();
+    deferred_invoke([this](auto& object) {
+        NonnullRefPtr protector { object };
+        remove_from_parent();
+    });
 }

 void Client::start()