mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 15:49:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Correct "percentages-resolve-to" data for properties

Browse source 
These were missing for properties that take a `<position>`, and were
incorrectly present for opacity-related properties.
This commit is contained in:
Sam Atkins 2025-01-31 11:46:18 +00:00 • committed by Alexander Kalenik
commit 6ebe19d13b
Notes: github-actions[bot] 2025-01-31 13:25:41 +00:00
2 changed files with 11 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Libraries/LibWeb/CSS/Properties.json
View file

@ -383,7 +383,8 @@
"longhands": [ "longhands": [
"background-position-x", "background-position-x",
"background-position-y" "background-position-y"
] ],
"percentages-resolve-to": "length"
}, },
"background-position-x": { "background-position-x": {
"affects-layout": false, "affects-layout": false,
@ -613,7 +614,8 @@
"border-top-right-radius", "border-top-right-radius",
"border-bottom-left-radius", "border-bottom-left-radius",
"border-bottom-right-radius" "border-bottom-right-radius"
] ],
"percentages-resolve-to": "length"
}, },
"border-right": { "border-right": {
"inherited": false, "inherited": false,
@ -1083,8 +1085,7 @@
"valid-types": [ "valid-types": [
"number [-∞,∞]", "number [-∞,∞]",
"percentage [-∞,∞]" "percentage [-∞,∞]"
], ]
"percentages-resolve-to": "number"
}, },
"fill-rule": { "fill-rule": {
"affects-layout": false, "affects-layout": false,
@ -2130,7 +2131,8 @@
"initial": "50% 50%", "initial": "50% 50%",
"valid-types": [ "valid-types": [
"position" "position"
] ],
"percentages-resolve-to": "length"
}, },
"opacity": { "opacity": {
"animation-type": "by-computed-value", "animation-type": "by-computed-value",
@ -2142,7 +2144,7 @@
"number [-∞,∞]", "number [-∞,∞]",
"percentage [-∞,∞]" "percentage [-∞,∞]"
], ],
"percentages-resolve-to": "number" "__comment": "We don't have a percentages-resolve-to here because even though we're supposed to map percentages to [0,1], calc(10%) should resolve to 10% not 0.1."
}, },
"order": { "order": {
"animation-type": "by-computed-value", "animation-type": "by-computed-value",
@ -2530,7 +2532,7 @@
"number [-∞,∞]", "number [-∞,∞]",
"percentage [-∞,∞]" "percentage [-∞,∞]"
], ],
"percentages-resolve-to": "number" "__comment": "We don't have a percentages-resolve-to here for the same reason as for opacity."
}, },
"stroke": { "stroke": {
"affects-layout": false, "affects-layout": false,
@ -2595,7 +2597,7 @@
"number [-∞,∞]", "number [-∞,∞]",
"percentage [-∞,∞]" "percentage [-∞,∞]"
], ],
"percentages-resolve-to": "number" "__comment": "We don't have a percentages-resolve-to here for the same reason as for opacity."
}, },
"stroke-width": { "stroke-width": {
"affects-layout": false, "affects-layout": false,

2
Tests/LibWeb/Text/expected/css/calc-coverage.txt
View file

@ -139,7 +139,7 @@ ry: 'calc(2% * var(--n))' -> 'calc(2% * 2)'
stop-opacity: 'calc(2)' -> '2' stop-opacity: 'calc(2)' -> '2'
stop-opacity: 'calc(2 * var(--n))' -> '4' stop-opacity: 'calc(2 * var(--n))' -> '4'
stroke-opacity: 'calc(2%)' -> '2%' stroke-opacity: 'calc(2%)' -> '2%'
stroke-opacity: 'calc(2% * var(--n))' -> 'calc(2% * 2)' stroke-opacity: 'calc(2% * var(--n))' -> '4%'
stroke-width: 'calc(2px)' -> '2px' stroke-width: 'calc(2px)' -> '2px'
stroke-width: 'calc(2px * var(--n))' -> '4px' stroke-width: 'calc(2px * var(--n))' -> '4px'
tab-size: 'calc(2px)' -> '2px' tab-size: 'calc(2px)' -> '2px'