mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-12 20:42:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

headless-browser: Only rebaseline tests that would have failed

Browse source 
We have a bit of forgiveness around allowing tests to pass with varying
trailing newlines. Only write a rebaselined test to disk if it would not
have passed under those conditions.
This commit is contained in:
Timothy Flynn 2024-10-08 17:28:04 -04:00 • committed by Alexander Kalenik
commit 6eca60504e
Notes: github-actions[bot] 2024-10-08 23:46:54 +00:00
1 changed files with 20 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Userland/Utilities/headless-browser.cpp
View file

@ -339,27 +339,33 @@ static void run_dump_test(HeadlessWebContentView& view, Test& test, URL::URL con
return TestResult::Pass; return TestResult::Pass;
} }
auto expectation_file_or_error = Core::File::open(test.expectation_path, Application::the().rebaseline ? Core::File::OpenMode::Write : Core::File::OpenMode::Read); auto open_expectation_file = [&](auto mode) {
if (expectation_file_or_error.is_error()) { auto expectation_file_or_error = Core::File::open(test.expectation_path, mode);
warnln("Failed opening '{}': {}", test.expectation_path, expectation_file_or_error.error()); if (expectation_file_or_error.is_error())
return expectation_file_or_error.release_error(); warnln("Failed opening '{}': {}", test.expectation_path, expectation_file_or_error.error());
}
auto expectation_file = expectation_file_or_error.release_value(); return expectation_file_or_error;
};
ByteBuffer expectation;
{
auto expectation_file = TRY(open_expectation_file(Core::File::OpenMode::Read));
expectation = TRY(expectation_file->read_until_eof());
auto result_trimmed = StringView { test.text }.trim("\n"sv, TrimMode::Right);
auto expectation_trimmed = StringView { expectation }.trim("\n"sv, TrimMode::Right);
if (result_trimmed == expectation_trimmed)
return TestResult::Pass;
}
if (Application::the().rebaseline) { if (Application::the().rebaseline) {
auto expectation_file = TRY(open_expectation_file(Core::File::OpenMode::Write));
TRY(expectation_file->write_until_depleted(test.text)); TRY(expectation_file->write_until_depleted(test.text));
return TestResult::Pass; return TestResult::Pass;
} }
auto expectation = TRY(expectation_file->read_until_eof());
auto result_trimmed = StringView { test.text }.trim("\n"sv, TrimMode::Right);
auto expectation_trimmed = StringView { expectation }.trim("\n"sv, TrimMode::Right);
if (result_trimmed == expectation_trimmed)
return TestResult::Pass;
auto const color_output = isatty(STDOUT_FILENO) ? Diff::ColorOutput::Yes : Diff::ColorOutput::No; auto const color_output = isatty(STDOUT_FILENO) ? Diff::ColorOutput::Yes : Diff::ColorOutput::No;
if (color_output == Diff::ColorOutput::Yes) if (color_output == Diff::ColorOutput::Yes)