mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-22 02:01:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibWeb/HTML/HTMLScriptElement.h
View file

@ -14,10 +14,9 @@
namespace Web::HTML {
class HTMLScriptElement final : public HTMLElement {
public:
using WrapperType = Bindings::HTMLScriptElementWrapper;
WEB_PLATFORM_OBJECT(HTMLScriptElement, HTMLElement);
HTMLScriptElement(DOM::Document&, DOM::QualifiedName);
public:
virtual ~HTMLScriptElement() override;
bool is_non_blocking() const { return m_non_blocking; }
@ -25,7 +24,7 @@ public:
bool failed_to_load() const { return m_failed_to_load; }
template<OneOf<XMLDocumentBuilder, HTMLParser> T>
void set_parser_document(Badge<T>, DOM::Document& document) { m_parser_document = document; }
void set_parser_document(Badge<T>, DOM::Document& document) { m_parser_document = &document; }
template<OneOf<XMLDocumentBuilder, HTMLParser> T>
void set_non_blocking(Badge<T>, bool b) { m_non_blocking = b; }
@ -51,13 +50,17 @@ public:
void set_source_line_number(Badge<HTMLParser>, size_t source_line_number) { m_source_line_number = source_line_number; }
private:
HTMLScriptElement(DOM::Document&, DOM::QualifiedName);
virtual void visit_edges(Cell::Visitor&) override;
void prepare_script();
void script_became_ready();
void when_the_script_is_ready(Function<void()>);
void begin_delaying_document_load_event(DOM::Document&);
WeakPtr<DOM::Document> m_parser_document;
WeakPtr<DOM::Document> m_preparation_time_document;
JS::GCPtr<DOM::Document> m_parser_document;
JS::GCPtr<DOM::Document> m_preparation_time_document;
bool m_non_blocking { false };
bool m_already_started { false };
bool m_from_an_external_file { false };
@ -82,3 +85,5 @@ private:
};
}
WRAPPER_HACK(HTMLScriptElement, Web::HTML)