mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-28 07:18:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Let HTML parser handle EOF inserted by document.close()

Browse source 
Before this change, the explicit EOF inserted by document.close() would
instantly abort the parser. This meant that parsing algorithms that ran
as part of the parser unwinding on EOF would never actually run.

591 new passes in WPT/html/syntax/parsing/ :^)

This exposed a problem where the parser would try to insert a root
<html> element on EOF in a document where someone already inserted such
an element via direct DOM manipulation. The parser now gracefully
handles this scenario. It's covered by existing tests (which would
crash without this change.)
This commit is contained in:
Andreas Kling 2025-02-19 12:05:51 +01:00 • committed by Andreas Kling
parent dc652aee75
commit 6f7b865cd1
Notes: github-actions[bot] 2025-02-20 13:33:49 +00:00
48 changed files with 669 additions and 685 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -199,9 +199,6 @@ void HTMLParser::run(HTMLTokenizer::StopAtInsertionPoint stop_at_insertion_point
dbgln_if(HTML_PARSER_DEBUG, "[{}] {}", insertion_mode_name(), token.to_string());
if (token.is_end_of_file() && m_tokenizer.is_eof_inserted())
break;
// https://html.spec.whatwg.org/multipage/parsing.html#tree-construction-dispatcher
// As each token is emitted from the tokenizer, the user agent must follow the appropriate steps from the following list, known as the tree construction dispatcher:
if (m_stack_of_open_elements.is_empty()
@ -229,6 +226,9 @@ void HTMLParser::run(HTMLTokenizer::StopAtInsertionPoint stop_at_insertion_point
process_using_the_rules_for_foreign_content(token);
}
if (token.is_end_of_file() && m_tokenizer.is_eof_inserted())
break;
if (m_stop_parsing) {
dbgln_if(HTML_PARSER_DEBUG, "Stop parsing{}! :^)", m_parsing_fragment ? " fragment" : "");
break;
@ -633,10 +633,18 @@ void HTMLParser::handle_before_html(HTMLToken& token)
// -> Anything else
AnythingElse:
// Create an html element whose node document is the Document object. Append it to the Document object. Put this element in the stack of open elements.
auto element = create_element(document(), HTML::TagNames::html, Namespace::HTML).release_value_but_fixme_should_propagate_errors();
MUST(document().append_child(element));
m_stack_of_open_elements.push(element);
// AD-HOC: First check if we've already inserted a <html> element into the document.
// This can happen by mixing document.write() and DOM manipulation.
if (auto* html_element = document().document_element(); html_element && html_element->is_html_html_element()) {
m_stack_of_open_elements.push(*html_element);
} else {
auto element = create_element(document(), HTML::TagNames::html, Namespace::HTML).release_value_but_fixme_should_propagate_errors();
MUST(document().append_child(element));
m_stack_of_open_elements.push(element);
}
// Switch the insertion mode to "before head", then reprocess the token.
m_insertion_mode = InsertionMode::BeforeHead;