mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 20:45:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

UI: Pass parent WebView by non-const ref when creating children

Browse source 
We need to call non-const methods on this guy and access its members in
a non-const way.
This commit is contained in:
Andrew Kaster 2025-04-15 15:54:30 -06:00 • committed by Andrew Kaster
parent 5c4b65996e
commit 6ff0373556
Notes: github-actions[bot] 2025-04-16 16:43:45 +00:00
6 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
UI/AppKit/Interface/LadybirdWebViewBridge.cpp
View file

@ -147,7 +147,7 @@ void WebViewBridge::initialize_client(CreateNewClient create_new_client)
}
}
void WebViewBridge::initialize_client_as_child(WebViewBridge const& parent, u64 page_index)
void WebViewBridge::initialize_client_as_child(WebViewBridge& parent, u64 page_index)
{
m_client_state.client = parent.client();
m_client_state.page_index = page_index;

2
UI/AppKit/Interface/LadybirdWebViewBridge.h
View file

@ -24,7 +24,7 @@ public:
virtual ~WebViewBridge() override;
virtual void initialize_client(CreateNewClient = CreateNewClient::Yes) override;
void initialize_client_as_child(WebViewBridge const& parent, u64 page_index);
void initialize_client_as_child(WebViewBridge& parent, u64 page_index);
float device_pixel_ratio() const { return m_device_pixel_ratio; }
void set_device_pixel_ratio(float device_pixel_ratio);

2
UI/Headless/Application.cpp
View file

@ -110,7 +110,7 @@ HeadlessWebView& Application::create_web_view(Core::AnonymousBuffer theme, Web::
return *m_web_views.last();
}
HeadlessWebView& Application::create_child_web_view(HeadlessWebView const& parent, u64 page_index)
HeadlessWebView& Application::create_child_web_view(HeadlessWebView& parent, u64 page_index)
{
auto web_view = HeadlessWebView::create_child(parent, page_index);
m_web_views.append(move(web_view));

2
UI/Headless/Application.h
View file

@ -34,7 +34,7 @@ public:
ErrorOr<void> launch_test_fixtures();
HeadlessWebView& create_web_view(Core::AnonymousBuffer theme, Web::DevicePixelSize window_size);
HeadlessWebView& create_child_web_view(HeadlessWebView const&, u64 page_index);
HeadlessWebView& create_child_web_view(HeadlessWebView&, u64 page_index);
void destroy_web_views();
template<typename Callback>

2
UI/Headless/HeadlessWebView.cpp
View file

@ -138,7 +138,7 @@ NonnullOwnPtr<HeadlessWebView> HeadlessWebView::create(Core::AnonymousBuffer the
return view;
}
NonnullOwnPtr<HeadlessWebView> HeadlessWebView::create_child(HeadlessWebView const& parent, u64 page_index)
NonnullOwnPtr<HeadlessWebView> HeadlessWebView::create_child(HeadlessWebView& parent, u64 page_index)
{
auto view = adopt_own(*new HeadlessWebView(parent.m_theme, parent.m_viewport_size));

2
UI/Headless/HeadlessWebView.h
View file

@ -21,7 +21,7 @@ namespace Ladybird {
class HeadlessWebView final : public WebView::ViewImplementation {
public:
static NonnullOwnPtr<HeadlessWebView> create(Core::AnonymousBuffer theme, Web::DevicePixelSize window_size);
static NonnullOwnPtr<HeadlessWebView> create_child(HeadlessWebView const&, u64 page_index);
static NonnullOwnPtr<HeadlessWebView> create_child(HeadlessWebView&, u64 page_index);
void clear_content_filters();