mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-01 16:02:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibWeb: Make base URL of HTML::Script Optional

Browse source 
This is a null or a URL in the spec, which we were previously
representing through the invalid state of URL.
This commit is contained in:
Shannon Booth 2025-02-16 15:53:04 +13:00 • committed by Tim Flynn
parent d62cf0a807
commit 705001483a
Notes: github-actions[bot] 2025-02-19 13:02:39 +00:00
5 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/HTML/Scripting/Script.h
View file

@ -24,7 +24,7 @@ class Script
public:
virtual ~Script() override;
URL::URL const& base_url() const { return m_base_url; }
Optional<URL::URL> const& base_url() const { return m_base_url; }
ByteString const& filename() const { return m_filename; }
JS::Realm& realm() { return m_realm; }
@ -37,14 +37,14 @@ public:
void set_parse_error(JS::Value value) { m_parse_error = value; }
protected:
Script(URL::URL base_url, ByteString filename, JS::Realm&);
Script(Optional<URL::URL> base_url, ByteString filename, JS::Realm&);
virtual void visit_edges(Visitor&) override;
private:
virtual void visit_host_defined_self(JS::Cell::Visitor&) override;
URL::URL m_base_url;
Optional<URL::URL> m_base_url;
ByteString m_filename;
GC::Ref<JS::Realm> m_realm;