mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-24 00:49:46 +00:00
LibJS+LibWeb: Port interned bytecode strings to UTF-16
This was almost a no-op, except we intern JS exception messages. So the bulk of this patch is porting exception messages to UTF-16.
This commit is contained in:
Timothy Flynn
Jelle Raaijmakers
parent
cf61171864
commit
70db474cf0
Notes:
github-actions[bot]
2025-08-14 08:28:16 +00:00
Author: https://github.com/trflynn89
Commit: 70db474cf0
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5845
Reviewed-by: https://github.com/gmta ✅
162 changed files with 1405 additions and 1422 deletions
|
|
@ -64,19 +64,19 @@ WebIDL::ExceptionOr<GC::Ref<AudioNode>> AudioNode::connect(GC::Ref<AudioNode> de
|
|||
|
||||
// If the destination parameter is an AudioNode that has been created using another AudioContext, an InvalidAccessError MUST be thrown.
|
||||
if (m_context != destination_node->m_context) {
|
||||
return WebIDL::InvalidAccessError::create(realm(), "Cannot connect to an AudioNode in a different AudioContext"_string);
|
||||
return WebIDL::InvalidAccessError::create(realm(), "Cannot connect to an AudioNode in a different AudioContext"_utf16);
|
||||
}
|
||||
|
||||
// The output parameter is an index describing which output of the AudioNode from which to connect.
|
||||
// If this parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (output >= number_of_outputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Output index {} exceeds number of outputs", output)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Output index {} exceeds number of outputs", output));
|
||||
}
|
||||
|
||||
// The input parameter is an index describing which input of the destination AudioNode to connect to.
|
||||
// If this parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (input >= destination_node->number_of_inputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Input index '{}' exceeds number of inputs", input)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Input index '{}' exceeds number of inputs", input));
|
||||
}
|
||||
// Connect node's output to destination_node input.
|
||||
m_output_connections.append(output_connection);
|
||||
|
|
@ -101,13 +101,13 @@ WebIDL::ExceptionOr<void> AudioNode::connect(GC::Ref<AudioParam> destination_par
|
|||
// If destinationParam belongs to an AudioNode that belongs to a BaseAudioContext that is different from the BaseAudioContext
|
||||
// that has created the AudioNode on which this method was called, an InvalidAccessError MUST be thrown.
|
||||
if (m_context != destination_param->context()) {
|
||||
return WebIDL::InvalidAccessError::create(realm(), "Cannot connect to an AudioParam in a different AudioContext"_string);
|
||||
return WebIDL::InvalidAccessError::create(realm(), "Cannot connect to an AudioParam in a different AudioContext"_utf16);
|
||||
}
|
||||
|
||||
// The output parameter is an index describing which output of the AudioNode from which to connect.
|
||||
// If the parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (output >= number_of_outputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Output index {} exceeds number of outputs", output)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Output index {} exceeds number of outputs", output));
|
||||
}
|
||||
|
||||
// Connect node's output to destination_param.
|
||||
|
|
@ -138,7 +138,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(WebIDL::UnsignedLong output)
|
|||
// It disconnects all outgoing connections from the given output.
|
||||
// If this parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (output >= number_of_outputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Output index {} exceeds number of outputs", output)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Output index {} exceeds number of outputs", output));
|
||||
}
|
||||
|
||||
m_output_connections.remove_all_matching([&](AudioNodeConnection& connection) {
|
||||
|
|
@ -177,7 +177,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioNode> destination_n
|
|||
});
|
||||
// If there is no connection to the destinationNode, an InvalidAccessError exception MUST be thrown.
|
||||
if (m_output_connections.size() == before) {
|
||||
return WebIDL::InvalidAccessError::create(realm(), MUST(String::formatted("No connection to given AudioNode")));
|
||||
return WebIDL::InvalidAccessError::create(realm(), Utf16String::formatted("No connection to given AudioNode"));
|
||||
}
|
||||
|
||||
return {};
|
||||
|
|
@ -189,7 +189,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioNode> destination_n
|
|||
// The output parameter is an index describing which output of the AudioNode from which to disconnect.
|
||||
// If this parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (output >= number_of_outputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Output index {} exceeds number of outputs", output)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Output index {} exceeds number of outputs", output));
|
||||
}
|
||||
|
||||
// The destinationNode parameter is the AudioNode to disconnect.
|
||||
|
|
@ -207,7 +207,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioNode> destination_n
|
|||
|
||||
// If there is no connection to the destinationNode from the given output, an InvalidAccessError exception MUST be thrown.
|
||||
if (m_output_connections.size() == before) {
|
||||
return WebIDL::InvalidAccessError::create(realm(), MUST(String::formatted("No connection from output {} to given AudioNode", output)));
|
||||
return WebIDL::InvalidAccessError::create(realm(), Utf16String::formatted("No connection from output {} to given AudioNode", output));
|
||||
}
|
||||
|
||||
return {};
|
||||
|
|
@ -219,13 +219,13 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioNode> destination_n
|
|||
// The output parameter is an index describing which output of the AudioNode from which to disconnect.
|
||||
// If this parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (output >= number_of_outputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Output index {} exceeds number of outputs", output)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Output index {} exceeds number of outputs", output));
|
||||
}
|
||||
|
||||
// The input parameter is an index describing which input of the destination AudioNode to disconnect.
|
||||
// If this parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (input >= destination_node->number_of_inputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Input index '{}' exceeds number of inputs", input)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Input index '{}' exceeds number of inputs", input));
|
||||
}
|
||||
|
||||
// The destinationNode parameter is the AudioNode to disconnect.
|
||||
|
|
@ -243,7 +243,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioNode> destination_n
|
|||
|
||||
// If there is no connection to the destinationNode from the given output to the given input, an InvalidAccessError exception MUST be thrown.
|
||||
if (m_output_connections.size() == before) {
|
||||
return WebIDL::InvalidAccessError::create(realm(), MUST(String::formatted("No connection from output {} to input {} of given AudioNode", output, input)));
|
||||
return WebIDL::InvalidAccessError::create(realm(), Utf16String::formatted("No connection from output {} to input {} of given AudioNode", output, input));
|
||||
}
|
||||
|
||||
return {};
|
||||
|
|
@ -260,7 +260,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioParam> destination_
|
|||
|
||||
// If there is no connection to the destinationParam, an InvalidAccessError exception MUST be thrown.
|
||||
if (m_param_connections.size() == before) {
|
||||
return WebIDL::InvalidAccessError::create(realm(), MUST(String::formatted("No connection to given AudioParam")));
|
||||
return WebIDL::InvalidAccessError::create(realm(), Utf16String::formatted("No connection to given AudioParam"));
|
||||
}
|
||||
|
||||
return {};
|
||||
|
|
@ -272,7 +272,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioParam> destination_
|
|||
// The output parameter is an index describing which output of the AudioNode from which to disconnect.
|
||||
// If this parameter is out-of-bounds, an IndexSizeError exception MUST be thrown.
|
||||
if (output >= number_of_outputs()) {
|
||||
return WebIDL::IndexSizeError::create(realm(), MUST(String::formatted("Output index {} exceeds number of outputs", output)));
|
||||
return WebIDL::IndexSizeError::create(realm(), Utf16String::formatted("Output index {} exceeds number of outputs", output));
|
||||
}
|
||||
// The destinationParam parameter is the AudioParam to disconnect.
|
||||
auto before = m_param_connections.size();
|
||||
|
|
@ -282,7 +282,7 @@ WebIDL::ExceptionOr<void> AudioNode::disconnect(GC::Ref<AudioParam> destination_
|
|||
|
||||
// If there is no connection to the destinationParam, an InvalidAccessError exception MUST be thrown.
|
||||
if (m_param_connections.size() == before) {
|
||||
return WebIDL::InvalidAccessError::create(realm(), MUST(String::formatted("No connection from output {} to given AudioParam", output)));
|
||||
return WebIDL::InvalidAccessError::create(realm(), Utf16String::formatted("No connection from output {} to given AudioParam", output));
|
||||
}
|
||||
|
||||
return {};
|
||||
|
|
@ -294,7 +294,7 @@ WebIDL::ExceptionOr<void> AudioNode::set_channel_count(WebIDL::UnsignedLong chan
|
|||
// If this value is set to zero or to a value greater than the implementation’s maximum number
|
||||
// of channels the implementation MUST throw a NotSupportedError exception.
|
||||
if (channel_count == 0 || channel_count > BaseAudioContext::MAX_NUMBER_OF_CHANNELS)
|
||||
return WebIDL::NotSupportedError::create(realm(), "Invalid channel count"_string);
|
||||
return WebIDL::NotSupportedError::create(realm(), "Invalid channel count"_utf16);
|
||||
|
||||
m_channel_count = channel_count;
|
||||
return {};
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue