mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-18 15:01:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't mark <input type="color"> as closed until the picker is

Browse source 
The color picker implementation allows for live updates to the input
element until the final color is confirmed by the user, but previously
it was marked as closed immediately after the first update.
This commit is contained in:
circl 2025-06-27 13:51:56 +02:00 • committed by Sam Atkins
parent a14471b89b
commit 7152821c8f
Notes: github-actions[bot] 2025-06-27 14:16:22 +00:00
1 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -542,8 +542,6 @@ void HTMLInputElement::did_edit_text_node()
void HTMLInputElement::did_pick_color(Optional<Color> picked_color, ColorPickerUpdateState state)
{
set_is_open(false);
if (type_state() == TypeAttributeState::Color && picked_color.has_value()) {
// then when the user changes the element's value
m_value = value_sanitization_algorithm(picked_color.value().to_string_without_alpha());
@ -554,12 +552,13 @@ void HTMLInputElement::did_pick_color(Optional<Color> picked_color, ColorPickerU
// the user agent must queue an element task on the user interaction task source
user_interaction_did_change_input_value();
// https://html.spec.whatwg.org/multipage/input.html#common-input-element-events
// [...] any time the user commits the change, the user agent must queue an element task on the user interaction task source
if (state == ColorPickerUpdateState::Closed) {
set_is_open(false);
// https://html.spec.whatwg.org/multipage/input.html#common-input-element-events
// [...] any time the user commits the change, the user agent must queue an element task on the user interaction task source given the input element to
queue_an_element_task(HTML::Task::Source::UserInteraction, [this] {
// given the input element
// to set its user validity to true
// set its user validity to true
m_user_validity = true;
// and fire an event named change at the input element, with the bubbles attribute initialized to true.
auto change_event = DOM::Event::create(realm(), HTML::EventNames::change);
@ -1327,7 +1326,7 @@ void HTMLInputElement::user_interaction_did_change_input_value()
});
// and any time the user commits the change, the user agent must queue an element task on the user interaction task source given the input
// element to set its user validity to true and fire an event named change at the input element, with the bubbles attribute initialized to true.
// FIXME: Does this need to happen here?
// NOTE: This is done manually as needed
}
void HTMLInputElement::update_slider_shadow_tree_elements()