mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 13:49:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implement cloning steps for HTMLInputElement

Browse source
This commit is contained in:
Tim Ledbetter 2024-08-21 12:19:37 +01:00 • committed by Andreas Kling
commit 71cfa705d1
Notes: github-actions[bot] 2024-08-25 10:54:28 +00:00
4 changed files with 39 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/HTML/HTMLInputElement-cloning-steps.txt Normal file
View file

@ -0,0 +1,2 @@
Cloned checkbox checked: true
Cloned text input value: PASS

23
Tests/LibWeb/Text/input/HTML/HTMLInputElement-cloning-steps.html Normal file
View file

@ -0,0 +1,23 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<form>
<input id="checkedCheckbox" type="checkbox">
<input type="text" value="FAIL">
</form>
<script>
test(() => {
const form = document.forms[0];
const inputs = form.getElementsByTagName("input");
inputs[0].checked = true;
inputs[1].value = "PASS";
const clone = form.cloneNode(true);
document.body.appendChild(clone);
println(`Cloned checkbox checked: ${clone.querySelector("input[type=checkbox]").checked}`);
println(`Cloned text input value: ${clone.querySelector("input[type=text]").value}`);
form.remove();
clone.remove();
});
</script>

12
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -1446,6 +1446,18 @@ void HTMLInputElement::form_associated_element_was_removed(DOM::Node*)
set_shadow_root(nullptr); set_shadow_root(nullptr);
} }
// https://html.spec.whatwg.org/multipage/input.html#the-input-element%3Aconcept-node-clone-ext
WebIDL::ExceptionOr<void> HTMLInputElement::cloned(DOM::Node& copy, bool)
{
// The cloning steps for input elements must propagate the value, dirty value flag, checkedness, and dirty checkedness flag from the node being cloned to the copy.
auto& input_clone = verify_cast<HTMLInputElement>(copy);
input_clone.m_value = m_value;
input_clone.m_dirty_value = m_dirty_value;
input_clone.m_checked = m_checked;
input_clone.m_dirty_checkedness = m_dirty_checkedness;
return {};
}
// https://html.spec.whatwg.org/multipage/input.html#radio-button-group // https://html.spec.whatwg.org/multipage/input.html#radio-button-group
static bool is_in_same_radio_button_group(HTML::HTMLInputElement const& a, HTML::HTMLInputElement const& b) static bool is_in_same_radio_button_group(HTML::HTMLInputElement const& a, HTML::HTMLInputElement const& b)
{ {

2
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -176,6 +176,8 @@ public:
virtual void form_associated_element_was_removed(DOM::Node*) override; virtual void form_associated_element_was_removed(DOM::Node*) override;
virtual void form_associated_element_attribute_changed(FlyString const&, Optional<String> const&) override; virtual void form_associated_element_attribute_changed(FlyString const&, Optional<String> const&) override;
virtual WebIDL::ExceptionOr<void> cloned(Node&, bool) override;
JS::NonnullGCPtr<ValidityState const> validity() const; JS::NonnullGCPtr<ValidityState const> validity() const;
// ^HTMLElement // ^HTMLElement