mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 22:30:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Reject radial-gradient functions with negative size

Browse source
This commit is contained in:
Tim Ledbetter 2025-03-11 15:25:00 +00:00 • committed by Sam Atkins
commit 764b80a1cc
Notes: github-actions[bot] 2025-03-14 15:09:31 +00:00
3 changed files with 64 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/CSS/Parser/GradientParsing.cpp
View file

@ -545,6 +545,14 @@ RefPtr<RadialGradientStyleValue> Parser::parse_radial_gradient_function(TokenStr
return {};
};
auto length_percentage_is_non_negative = [](LengthPercentage const& length_percentage) -> bool {
if (length_percentage.is_length() && length_percentage.length().raw_value() < 0)
return false;
if (length_percentage.is_percentage() && length_percentage.percentage().value() < 0)
return false;
return true;
};
auto parse_size = [&]() -> Optional<Size> {
// <size> =
// <extent-keyword> |
@ -561,15 +569,18 @@ RefPtr<RadialGradientStyleValue> Parser::parse_radial_gradient_function(TokenStr
return commit_value(*extent, transaction_size);
}
auto first_radius = parse_length_percentage(tokens);
if (!first_radius.has_value())
if (!first_radius.has_value() || !length_percentage_is_non_negative(*first_radius))
return {};
auto transaction_second_dimension = tokens.begin_transaction();
tokens.discard_whitespace();
if (tokens.has_next_token()) {
auto second_radius = parse_length_percentage(tokens);
if (second_radius.has_value())
if (second_radius.has_value()) {
if (!length_percentage_is_non_negative(*second_radius))
return {};
return commit_value(EllipseSize { first_radius.release_value(), second_radius.release_value() },
transaction_size, transaction_second_dimension);
}
}
// FIXME: Support calculated lengths
if (first_radius->is_length())