mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Reject radial-gradient functions with negative size

Browse source
This commit is contained in:
Tim Ledbetter 2025-03-11 15:25:00 +00:00 • committed by Sam Atkins
commit 764b80a1cc
Notes: github-actions[bot] 2025-03-14 15:09:31 +00:00
3 changed files with 64 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/CSS/Parser/GradientParsing.cpp
View file

@ -545,6 +545,14 @@ RefPtr<RadialGradientStyleValue> Parser::parse_radial_gradient_function(TokenStr
return {}; return {};
}; };
auto length_percentage_is_non_negative = [](LengthPercentage const& length_percentage) -> bool {
if (length_percentage.is_length() && length_percentage.length().raw_value() < 0)
return false;
if (length_percentage.is_percentage() && length_percentage.percentage().value() < 0)
return false;
return true;
};
auto parse_size = [&]() -> Optional<Size> { auto parse_size = [&]() -> Optional<Size> {
// <size> = // <size> =
// <extent-keyword> | // <extent-keyword> |
@ -561,15 +569,18 @@ RefPtr<RadialGradientStyleValue> Parser::parse_radial_gradient_function(TokenStr
return commit_value(*extent, transaction_size); return commit_value(*extent, transaction_size);
} }
auto first_radius = parse_length_percentage(tokens); auto first_radius = parse_length_percentage(tokens);
if (!first_radius.has_value()) if (!first_radius.has_value() || !length_percentage_is_non_negative(*first_radius))
return {}; return {};
auto transaction_second_dimension = tokens.begin_transaction(); auto transaction_second_dimension = tokens.begin_transaction();
tokens.discard_whitespace(); tokens.discard_whitespace();
if (tokens.has_next_token()) { if (tokens.has_next_token()) {
auto second_radius = parse_length_percentage(tokens); auto second_radius = parse_length_percentage(tokens);
if (second_radius.has_value()) if (second_radius.has_value()) {
if (!length_percentage_is_non_negative(*second_radius))
return {};
return commit_value(EllipseSize { first_radius.release_value(), second_radius.release_value() }, return commit_value(EllipseSize { first_radius.release_value(), second_radius.release_value() },
transaction_size, transaction_second_dimension); transaction_size, transaction_second_dimension);
}
} }
// FIXME: Support calculated lengths // FIXME: Support calculated lengths
if (first_radius->is_length()) if (first_radius->is_length())

17
Tests/LibWeb/Text/expected/wpt-import/css/css-backgrounds/parsing/background-image-invalid.txt Normal file
View file

@ -0,0 +1,17 @@
Harness status: OK
Found 12 tests
12 Pass
Pass e.style['background-image'] = "none, auto" should not set the property value
Pass e.style['background-image'] = "radial-gradient(circle -10px at center, red, blue)" should not set the property value
Pass e.style['background-image'] = "repeating-radial-gradient(-10px at center, red, blue)" should not set the property value
Pass e.style['background-image'] = "radial-gradient(ellipse -20px 30px at center, red, blue)" should not set the property value
Pass e.style['background-image'] = "repeating-radial-gradient(-20% 30% at center, red, blue)" should not set the property value
Pass e.style['background-image'] = "radial-gradient(20px -30px at center, red, blue)" should not set the property value
Pass e.style['background-image'] = "repeating-radial-gradient(20px -30px ellipse at center, red, blue)" should not set the property value
Pass e.style['background-image'] = "cross-fade(auto blue, 50% red)" should not set the property value
Pass e.style['background-image'] = "cross-fade(1px red, green)" should not set the property value
Pass e.style['background-image'] = "cross-fade(calc(1% + 1px) red, green)" should not set the property value
Pass e.style['background-image'] = "cross-fade(-1% red, green)" should not set the property value
Pass e.style['background-image'] = "cross-fade(101% red, green)" should not set the property value

34
Tests/LibWeb/Text/input/wpt-import/css/css-backgrounds/parsing/background-image-invalid.html Normal file
View file

@ -0,0 +1,34 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>CSS Backgrounds and Borders Module Level 3: parsing background-image with invalid values</title>
<link rel="author" title="Eric Willigers" href="mailto:ericwilligers@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-backgrounds/#background-image">
<link rel="help" href="https://drafts.csswg.org/css-images/#radial-gradients">
<meta name="assert" content="background-image supports only the grammar '<bg-image>#'.">
<meta name="assert" content="Negative radial-gradient radii are invalid.">
<script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script>
<script src="../../../css/support/parsing-testcommon.js"></script>
</head>
<body>
<script>
test_invalid_value("background-image", "none, auto");
// Negative radii are invalid.
test_invalid_value("background-image", "radial-gradient(circle -10px at center, red, blue)");
test_invalid_value("background-image", "repeating-radial-gradient(-10px at center, red, blue)");
test_invalid_value("background-image", "radial-gradient(ellipse -20px 30px at center, red, blue)");
test_invalid_value("background-image", "repeating-radial-gradient(-20% 30% at center, red, blue)");
test_invalid_value("background-image", "radial-gradient(20px -30px at center, red, blue)");
test_invalid_value("background-image", "repeating-radial-gradient(20px -30px ellipse at center, red, blue)");
test_invalid_value("background-image", "cross-fade(auto blue, 50% red)");
test_invalid_value("background-image", "cross-fade(1px red, green)");
test_invalid_value("background-image", "cross-fade(calc(1% + 1px) red, green)");
test_invalid_value("background-image", "cross-fade(-1% red, green)");
test_invalid_value("background-image", "cross-fade(101% red, green)");
</script>
</body>
</html>