mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-05 00:56:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Support calcs which resolve to numbers as hue values in colors

Browse source 
Gains us 5 new WPT tests.
This commit is contained in:
Callum Law 2025-07-03 23:20:10 +12:00 • committed by Sam Atkins
commit 778759517e
Notes: github-actions[bot] 2025-07-04 12:20:03 +00:00
3 changed files with 24 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibWeb/CSS/StyleValues/CSSColorValue.cpp
View file

@ -34,6 +34,14 @@ Optional<double> CSSColorValue::resolve_hue(CSSStyleValue const& style_value, Ca
{
// <number> | <angle> | none
auto normalized = [](double number) {
// +inf should be clamped to 360
if (!isfinite(number) && number > 0)
number = 360.0;
// -inf and NaN should be clamped to 0
if (!isfinite(number) || isnan(number))
number = 0.0;
return JS::modulo(number, 360.0);
};
@ -43,8 +51,13 @@ Optional<double> CSSColorValue::resolve_hue(CSSStyleValue const& style_value, Ca
if (style_value.is_angle())
return normalized(style_value.as_angle().angle().to_degrees());
if (style_value.is_calculated() && style_value.as_calculated().resolves_to_angle())
return normalized(style_value.as_calculated().resolve_angle(resolution_context).value().to_degrees());
if (style_value.is_calculated()) {
if (style_value.as_calculated().resolves_to_number())
return normalized(style_value.as_calculated().resolve_number(resolution_context).value());
if (style_value.as_calculated().resolves_to_angle())
return normalized(style_value.as_calculated().resolve_angle(resolution_context).value().to_degrees());
}
if (style_value.is_keyword() && style_value.to_keyword() == Keyword::None)
return 0;