mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-28 21:26:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Allow ImageProvider subclasses to visit additional GC edges

Browse source 
More prep work for CSS content:image.
This commit is contained in:
Andreas Kling 2025-07-26 14:54:12 +02:00 • committed by Andreas Kling
commit 77abe2a84d
Notes: github-actions[bot] 2025-07-28 20:48:07 +00:00
7 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -86,6 +86,7 @@ void HTMLImageElement::adopted_from(DOM::Document& old_document)
void HTMLImageElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
image_provider_visit_edges(visitor);
visitor.visit(m_current_request);
visitor.visit(m_pending_request);
visitor.visit(m_document_observer);

1
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -79,6 +79,7 @@ void HTMLInputElement::initialize(JS::Realm& realm)
void HTMLInputElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
image_provider_visit_edges(visitor);
visitor.visit(m_inner_text_element);
visitor.visit(m_text_node);
visitor.visit(m_placeholder_element);

1
Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -76,6 +76,7 @@ void HTMLObjectElement::initialize(JS::Realm& realm)
void HTMLObjectElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
image_provider_visit_edges(visitor);
visitor.visit(m_resource_request);
visitor.visit(m_document_observer);
}

2
Libraries/LibWeb/Layout/ImageBox.cpp
View file

@ -26,7 +26,7 @@ ImageBox::~ImageBox() = default;
void ImageBox::visit_edges(JS::Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_image_provider.to_html_element());
m_image_provider.image_provider_visit_edges(visitor);
}
void ImageBox::prepare_for_replaced_layout()

7
Libraries/LibWeb/Layout/ImageProvider.h
View file

@ -6,6 +6,7 @@
#pragma once
#include <LibGC/Cell.h>
#include <LibGfx/Size.h>
#include <LibWeb/Forward.h>
#include <LibWeb/PixelUnits.h>
@ -25,9 +26,13 @@ public:
virtual RefPtr<Gfx::ImmutableBitmap> current_image_bitmap(Gfx::IntSize) const = 0;
virtual void set_visible_in_viewport(bool) = 0;
virtual GC::Ptr<DOM::Element const> to_html_element() const = 0;
virtual void image_provider_visit_edges(GC::Cell::Visitor& visitor) const
{
visitor.visit(to_html_element());
}
protected:
virtual GC::Ptr<DOM::Element const> to_html_element() const = 0;
static void did_update_alt_text(ImageBox&);
};

2
Libraries/LibWeb/Painting/ImagePaintable.cpp
View file

@ -45,7 +45,7 @@ ImagePaintable::ImagePaintable(Layout::Box const& layout_box, Layout::ImageProvi
void ImagePaintable::visit_edges(JS::Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_image_provider.to_html_element());
m_image_provider.image_provider_visit_edges(visitor);
}
void ImagePaintable::finalize()

1
Libraries/LibWeb/SVG/SVGImageElement.cpp
View file

@ -36,6 +36,7 @@ void SVGImageElement::initialize(JS::Realm& realm)
void SVGImageElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
image_provider_visit_edges(visitor);
SVGURIReferenceMixin::visit_edges(visitor);
visitor.visit(m_x);
visitor.visit(m_y);