mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 20:15:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS: Remove errant assertion from ParseISODateTime

Browse source 
This is an editorial change in the Temporal proposal. See:
https://github.com/tc39/proposal-temporal/commit/728beeb
This commit is contained in:
Timothy Flynn 2024-12-05 10:12:47 -05:00 • committed by Tim Flynn
parent 0e81092685
commit 784e872851
Notes: github-actions[bot] 2024-12-05 21:06:31 +00:00
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp
View file

@ -1201,16 +1201,10 @@ ThrowCompletionOr<ParsedISODateTime> parse_iso_date_time(VM& vm, StringView iso_
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidCalendarIdentifier, *calendar);
}
// 4. If goal is TemporalMonthDayString and parseResult does not contain a DateYear Parse Node, then
if (goal == Production::TemporalMonthDayString && !parse_result->date_year.has_value()) {
// a. Assert: goal is the last element of allowedFormats.
// FIXME: Spec issue: This assertion is possibly incorrect.
// https://github.com/tc39/proposal-temporal/issues/3045
// VERIFY(goal == allowed_formats.last());
// b. Set yearAbsent to true.
// 4. If goal is TemporalMonthDayString and parseResult does not contain a DateYear Parse Node, set
// yearAbsent to true.
if (goal == Production::TemporalMonthDayString && !parse_result->date_year.has_value())
year_absent = true;
}
}
}