mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Serialize empty grid-template-* values correctly

Browse source 
Previously we would serialize these as the empty string. eg, this:

```
<div style="grid-auto-columns: auto"></div>
```

would have a computed `grid-auto-columns` value of ``.
This commit is contained in:
Sam Atkins 2024-10-14 14:32:27 +01:00 • committed by Andreas Kling
commit 7c2680b7ef
Notes: github-actions[bot] 2024-10-16 06:35:06 +00:00
3 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Text/expected/css/getComputedStyle-print-all.txt
View file

@ -116,9 +116,9 @@ grid-column-end: auto
grid-column-start: auto
grid-row-end: auto
grid-row-start: auto
grid-template-areas:
grid-template-columns:
grid-template-rows:
grid-template-areas: none
grid-template-columns: auto
grid-template-rows: auto
height: 2057px
inline-size: auto
inset-block-end: auto

3
Userland/Libraries/LibWeb/CSS/GridTrackSize.cpp
View file

@ -244,6 +244,9 @@ GridTrackSizeList GridTrackSizeList::make_none()
String GridTrackSizeList::to_string() const
{
if (m_list.is_empty())
return "auto"_string;
StringBuilder builder;
for (auto const& line_definition_or_name : m_list) {
if (!builder.is_empty())

5
Userland/Libraries/LibWeb/CSS/StyleValues/GridTemplateAreaStyleValue.cpp
View file

@ -1,7 +1,7 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2021, Tobias Christiansen <tobyase@serenityos.org>
* Copyright (c) 2021-2023, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2021-2024, Sam Atkins <sam@ladybird.org>
* Copyright (c) 2022-2023, MacDue <macdue@dueutil.tech>
*
* SPDX-License-Identifier: BSD-2-Clause
@ -18,6 +18,9 @@ ValueComparingNonnullRefPtr<GridTemplateAreaStyleValue> GridTemplateAreaStyleVal
String GridTemplateAreaStyleValue::to_string() const
{
if (m_grid_template_area.is_empty())
return "none"_string;
StringBuilder builder;
for (size_t y = 0; y < m_grid_template_area.size(); ++y) {
for (size_t x = 0; x < m_grid_template_area[y].size(); ++x) {