mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Userland: Fix unnecessary heap allocation of singleton objects

Browse source 
In order to avoid having multiple instances, we were keeping a pointer
to these singleton objects and only allocating them when it was null.

We have `__cxa_guard_{acquire,release}` in the userland, so there's no
need to do this dance, as the compiler will ensure that the constructors
are only called once.
This commit is contained in:
Daniel Bertalan 2022-01-28 21:22:13 +01:00 • committed by Andreas Kling
commit 7d11edbe17
Notes: sideshowbarker 2024-07-17 20:04:47 +09:00
9 changed files with 18 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/DisplayLink.cpp
View file

@ -31,10 +31,8 @@ private:
static HashMap<i32, RefPtr<DisplayLinkCallback>>& callbacks()
{
static HashMap<i32, RefPtr<DisplayLinkCallback>>* map;
if (!map)
map = new HashMap<i32, RefPtr<DisplayLinkCallback>>;
return *map;
static HashMap<i32, RefPtr<DisplayLinkCallback>> s_map;
return s_map;
}
static i32 s_next_callback_id = 1;