mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-28 13:18:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Allow layout nodes to have multiple paintables

Browse source 
CSS fragmentation implies 1:N relationship between layout nodes and
paintables. This change is a preparation for implementation of inline
fragmentation where InlinePaintable will be replaced with
PaintableWithLines corresponding to each line.
This commit is contained in:
Aliaksandr Kalenik 2024-10-14 16:07:56 +02:00 • committed by Alexander Kalenik
commit 7d22b1c5c8
Notes: github-actions[bot] 2024-10-16 18:26:52 +00:00
16 changed files with 90 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -221,11 +221,11 @@ void LayoutState::commit(Box& root)
// from the layout tree. This is done to ensure that we don't end up with any old-tree pointers
// when text paintables shift around in the tree.
root.for_each_in_inclusive_subtree([&](Layout::Node& node) {
node.set_paintable(nullptr);
node.clear_paintables();
return TraversalDecision::Continue;
});
root.document().for_each_shadow_including_inclusive_descendant([&](DOM::Node& node) {
node.set_paintable(nullptr);
node.clear_paintable();
return TraversalDecision::Continue;
});
@ -248,7 +248,7 @@ void LayoutState::commit(Box& root)
auto paintable = node.create_paintable();
node.set_paintable(paintable);
node.add_paintable(paintable);
// For boxes, transfer all the state needed for painting.
if (paintable && is<Painting::PaintableBox>(*paintable)) {
@ -351,7 +351,7 @@ void LayoutState::commit(Box& root)
}
for (auto* text_node : text_nodes) {
text_node->set_paintable(text_node->create_paintable());
text_node->add_paintable(text_node->create_paintable());
auto* paintable = text_node->paintable();
auto const& font = text_node->first_available_font();
auto const glyph_height = CSSPixels::nearest_value_for(font.pixel_size());