mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 05:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Align execute_async_script variable name with the latest spec

Browse source
This commit is contained in:
Tim Ledbetter 2024-12-12 10:24:50 +00:00 • committed by Tim Flynn
commit 7d2a037d03
Notes: github-actions[bot] 2024-12-12 13:17:13 +00:00
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/WebDriver/ExecuteScript.cpp
View file

@ -141,6 +141,7 @@ void execute_script(HTML::BrowsingContext const& browsing_context, ByteString bo
WebIDL::react_to_promise(promise, reaction_steps, reaction_steps); WebIDL::react_to_promise(promise, reaction_steps, reaction_steps);
} }
// https://w3c.github.io/webdriver/#execute-async-script
void execute_async_script(HTML::BrowsingContext const& browsing_context, ByteString body, GC::MarkedVector<JS::Value> arguments, Optional<u64> const& timeout_ms, GC::Ref<OnScriptComplete> on_complete) void execute_async_script(HTML::BrowsingContext const& browsing_context, ByteString body, GC::MarkedVector<JS::Value> arguments, Optional<u64> const& timeout_ms, GC::Ref<OnScriptComplete> on_complete)
{ {
auto const* document = browsing_context.active_document(); auto const* document = browsing_context.active_document();
@ -175,8 +176,7 @@ void execute_async_script(HTML::BrowsingContext const& browsing_context, ByteStr
// 2. Append resolvingFunctions.[[Resolve]] to arguments. // 2. Append resolvingFunctions.[[Resolve]] to arguments.
arguments.append(resolving_functions.resolve); arguments.append(resolving_functions.resolve);
// 3. Let result be the result of calling execute a function body, with arguments body and arguments. // 3. Let scriptResult be the result of calling execute a function body, with arguments body and arguments.
// FIXME: 'result' -> 'scriptResult' (spec issue)
auto script_result = execute_a_function_body(browsing_context, body, move(arguments)); auto script_result = execute_a_function_body(browsing_context, body, move(arguments));
// 4. If scriptResult.[[Type]] is not normal, then reject promise with value scriptResult.[[Value]], and abort these steps. // 4. If scriptResult.[[Type]] is not normal, then reject promise with value scriptResult.[[Value]], and abort these steps.