LibSQL: Remove infallible type conversions from SQL::Value

Force the callers to either know that the type is convertible, or to handle the conversion failure.
Author: https://github.com/trflynn89 Commit: 7d41b46a7d Pull-request: https://github.com/SerenityOS/serenity/pull/15312 Reviewed-by: https://github.com/alimpfard
2025-07-29 20:29:18 +00:00 · 2022-09-22 08:35:47 -04:00 · 2022-09-22 08:35:47 -04:00 · 7d41b46a7d · 2024-07-17 05:48:30 +09:00
commit 7d41b46a7d
parent af3980384b
8 changed files with 22 additions and 64 deletions
--- a/Userland/Libraries/LibSQL/AST/Select.cpp
+++ b/Userland/Libraries/LibSQL/AST/Select.cpp
@ -92,8 +92,8 @@ ResultOr<ResultSet> Select::execute(ExecutionContext& context) const
        context.current_row = &row;

        if (where_clause()) {
-            auto where_result = TRY(where_clause()->evaluate(context));
-            if (!where_result)
+            auto where_result = TRY(where_clause()->evaluate(context)).to_bool();
+            if (!where_result.has_value() || !where_result.value())
                continue;
        }