mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 19:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibTLS: Notify on_ready_to_read after handling fatal errors

Browse source 
The `on_ready_to_read` callback on the underlying socket will be called
for various reasons which do not always guarantee that the next read
operation will be successful. For example, the server might have sent an
alert or a TCP RST.

We handle fatal errors on the SSL connection before calling to the user
so that `can_read_without_blocking` does not falsely advertise. The same
checks should be performed there, but it is not possible due to the
function being const.
This commit is contained in:
devgianlu 2025-02-22 12:46:50 +01:00 • committed by Ali Mohammad Pur
parent 1563054a63
commit 7eace6af66
Notes: github-actions[bot] 2025-02-22 17:40:54 +00:00
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibTLS/TLSv12.cpp
View file

@ -154,6 +154,23 @@ TLSv12::TLSv12(NonnullOwnPtr<Core::TCPSocket> socket, SSL_CTX* ssl_ctx, SSL* ssl
, m_socket(move(socket))
{
m_socket->on_ready_to_read = [this] {
// There is something to read on the underlying TCP connection. This doesn't mean there is actual data to read from the SSL connection.
// For example, we might have received an alert or a connection reset.
char buffer[1];
auto ret = SSL_peek(m_ssl, buffer, 1);
if (ret <= 0) {
switch (SSL_get_error(m_ssl, ret)) {
case SSL_ERROR_SSL:
case SSL_ERROR_SYSCALL:
handle_fatal_error();
break;
default:
break;
}
}
// Now that we handled possible fatal errors, we can notify the user that there is data to read.
if (on_ready_to_read)
on_ready_to_read();
};