mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-03 08:08:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibGfx: Add Rect::unite()

Browse source 
The existing `::unite_horizontally()` and `::unite_vertically()` tests
did not properly test the edge cases where left/top in the Rect were
updated, so they get re-arranged a bit.
This commit is contained in:
Jelle Raaijmakers 2025-01-15 13:51:39 +01:00 • committed by Jelle Raaijmakers
commit 7eb4f3da37
Notes: github-actions[bot] 2025-01-23 08:34:31 +00:00
7 changed files with 51 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

41
Tests/LibGfx/TestRect.cpp
View file

@ -57,28 +57,41 @@ TEST_CASE(rect_closest_to)
EXPECT_EQ(screen_rect.side(closest), Gfx::IntRect::Side::Top);
}
TEST_CASE(rect_unite)
{
Gfx::IntRect rect_a { 10, 10, 100, 100 };
Gfx::IntRect rect_b { 50, 50, 60, 70 };
rect_a.unite(rect_b);
EXPECT_EQ(rect_a.left(), 10);
EXPECT_EQ(rect_a.right(), 110);
EXPECT_EQ(rect_a.top(), 10);
EXPECT_EQ(rect_a.bottom(), 120);
}
TEST_CASE(rect_unite_horizontally)
{
Gfx::IntRect rect { 10, 10, 100, 100 };
Gfx::IntRect huge_rect { 0, 0, 1000, 1000 };
Gfx::IntRect rect_a { 10, 10, 1000, 100 };
Gfx::IntRect rect_b { 0, 0, 100, 1000 };
rect.unite_horizontally(huge_rect);
rect_a.unite_horizontally(rect_b);
EXPECT_EQ(rect.left(), 0);
EXPECT_EQ(rect.right(), 1000);
EXPECT_EQ(rect.top(), 10);
EXPECT_EQ(rect.bottom(), 110);
EXPECT_EQ(rect_a.left(), 0);
EXPECT_EQ(rect_a.right(), 1010);
EXPECT_EQ(rect_a.top(), 10);
EXPECT_EQ(rect_a.bottom(), 110);
}
TEST_CASE(rect_unite_vertically)
{
Gfx::IntRect rect { 10, 10, 100, 100 };
Gfx::IntRect huge_rect { 0, 0, 1000, 1000 };
Gfx::IntRect rect_a { 10, 10, 1000, 1000 };
Gfx::IntRect rect_b { 0, 0, 100, 100 };
rect.unite_vertically(huge_rect);
rect_a.unite_vertically(rect_b);
EXPECT_EQ(rect.top(), 0);
EXPECT_EQ(rect.bottom(), 1000);
EXPECT_EQ(rect.left(), 10);
EXPECT_EQ(rect.right(), 110);
EXPECT_EQ(rect_a.top(), 0);
EXPECT_EQ(rect_a.bottom(), 1010);
EXPECT_EQ(rect_a.left(), 10);
EXPECT_EQ(rect_a.right(), 1010);
}