mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-22 18:22:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

LibWeb: Limit HTMLTextAreaElement attributes to allowed values

Browse source 
If `HTMLTextAreaElement.rows` or `HTMLTextAreaElement.cols`
is set to a value larger than 2147483647, then it should be set to its
default value.
This commit is contained in:
Tim Ledbetter 2024-11-26 21:14:32 +00:00 • committed by Andreas Kling
parent a8719a706b
commit 7fe3bf07e2
Notes: github-actions[bot] 2024-11-27 10:03:52 +00:00
3 changed files with 42 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -293,7 +293,7 @@ unsigned HTMLTextAreaElement::cols() const
{
// The cols and rows attributes are limited to only positive numbers with fallback. The cols IDL attribute's default value is 20.
if (auto cols_string = get_attribute(HTML::AttributeNames::cols); cols_string.has_value()) {
if (auto cols = parse_non_negative_integer(*cols_string); cols.has_value() && *cols > 0)
if (auto cols = parse_non_negative_integer(*cols_string); cols.has_value() && *cols > 0 && *cols <= 2147483647)
return *cols;
}
return 20;
@ -301,6 +301,9 @@ unsigned HTMLTextAreaElement::cols() const
WebIDL::ExceptionOr<void> HTMLTextAreaElement::set_cols(unsigned cols)
{
if (cols > 2147483647)
cols = 20;
return set_attribute(HTML::AttributeNames::cols, String::number(cols));
}
@ -309,7 +312,7 @@ unsigned HTMLTextAreaElement::rows() const
{
// The cols and rows attributes are limited to only positive numbers with fallback. The rows IDL attribute's default value is 2.
if (auto rows_string = get_attribute(HTML::AttributeNames::rows); rows_string.has_value()) {
if (auto rows = parse_non_negative_integer(*rows_string); rows.has_value() && *rows > 0)
if (auto rows = parse_non_negative_integer(*rows_string); rows.has_value() && *rows > 0 && *rows <= 2147483647)
return *rows;
}
return 2;
@ -317,6 +320,9 @@ unsigned HTMLTextAreaElement::rows() const
WebIDL::ExceptionOr<void> HTMLTextAreaElement::set_rows(unsigned rows)
{
if (rows > 2147483647)
rows = 2;
return set_attribute(HTML::AttributeNames::rows, String::number(rows));
}