From 7fe82a1cda3c290ba0f49d84e5051b2349227afd Mon Sep 17 00:00:00 2001 From: Daniel Bertalan Date: Sun, 14 Jul 2024 16:57:52 +0200 Subject: [PATCH] CMake: Add back stricter warnings used in Serenity builds These used to be enabled in `serenity_compile_options.cmake` for Serenity builds and were removed in 9b05fb98. This is a slightly more conservative subset of those, with ones that are enabled by default omitted. This should prevent our code quality regressing in the long run. --- Meta/CMake/common_compile_options.cmake | 6 +++++- Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Meta/CMake/common_compile_options.cmake b/Meta/CMake/common_compile_options.cmake index a2749e24b04..7f6cdd646d1 100644 --- a/Meta/CMake/common_compile_options.cmake +++ b/Meta/CMake/common_compile_options.cmake @@ -19,8 +19,12 @@ else() add_compile_options(-ffp-contract=off) endif() -add_compile_options(-Wno-invalid-offsetof) +add_compile_options(-Wcast-qual) +add_compile_options(-Wformat=2) +add_compile_options(-Wimplicit-fallthrough) +add_compile_options(-Wsuggest-override) +add_compile_options(-Wno-invalid-offsetof) add_compile_options(-Wno-unknown-warning-option) add_compile_options(-Wno-unused-command-line-argument) diff --git a/Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp b/Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp index a685ff98789..8f4e9b43d94 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp @@ -89,7 +89,7 @@ ErrorOr JPEGWriter::encode_impl(Stream& stream, auto const& bitmap, Option while (cinfo.next_scanline < cinfo.image_height) { auto const* row_ptr = reinterpret_cast(bitmap.scanline(cinfo.next_scanline)); - JSAMPROW row_pointer = (JSAMPROW)row_ptr; + JSAMPROW row_pointer = const_cast(row_ptr); jpeg_write_scanlines(&cinfo, &row_pointer, 1); }