mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Don't serialize empty rules in CSSMediaRule

Browse source 
This is a recent spec change:
https://github.com/w3c/csswg-drafts/pull/10981
This commit is contained in:
ronak69 2024-10-09 14:02:30 +00:00 • committed by Sam Atkins
commit 8003d63ff9
Notes: github-actions[bot] 2024-10-14 08:51:42 +00:00
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibWeb/CSS/CSSMediaRule.cpp
View file

@ -54,21 +54,23 @@ String CSSMediaRule::serialized() const
builder.append(condition_text()); builder.append(condition_text());
// 3. A single SPACE (U+0020), followed by the string "{", i.e., LEFT CURLY BRACKET (U+007B), followed by a newline. // 3. A single SPACE (U+0020), followed by the string "{", i.e., LEFT CURLY BRACKET (U+007B), followed by a newline.
builder.append(" {\n"sv); builder.append(" {\n"sv);
// AD-HOC: All modern browsers omit the ending newline if there are no CSS rules, so let's do the same. // 4. The result of performing serialize a CSS rule on each rule in the rule’s cssRules list,
if (css_rules().length() == 0) { // filtering out empty strings, indenting each item with two spaces, all joined with newline.
builder.append('}');
return MUST(builder.to_string());
}
// 4. The result of performing serialize a CSS rule on each rule in the rule’s cssRules list, separated by a newline and indented by two spaces.
for (size_t i = 0; i < css_rules().length(); i++) { for (size_t i = 0; i < css_rules().length(); i++) {
auto rule = css_rules().item(i); auto rule = css_rules().item(i);
if (i != 0) auto result = rule->css_text();
builder.append("\n"sv);
if (result.is_empty())
continue;
builder.append(" "sv); builder.append(" "sv);
builder.append(rule->css_text()); builder.append(result);
builder.append('\n');
} }
// 5. A newline, followed by the string "}", i.e., RIGHT CURLY BRACKET (U+007D) // 5. A newline, followed by the string "}", i.e., RIGHT CURLY BRACKET (U+007D)
builder.append("\n}"sv); // AD-HOC: All modern browsers omit the ending newline if there are no CSS rules, so let's do the same.
// If there are rules, the required newline will be appended in the for-loop above.
builder.append('}');
return MUST(builder.to_string()); return MUST(builder.to_string());
} }