From 80a6dc4da06515ed82bfee6e9dbcc9f4dea572bd Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 13 Aug 2025 17:22:06 +0100 Subject: [PATCH] LibIDL: Make ExposedTo an enum class --- Libraries/LibIDL/ExposedTo.cpp | 2 +- Libraries/LibIDL/ExposedTo.h | 2 +- .../LibWeb/GenerateWindowOrWorkerInterfaces.cpp | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Libraries/LibIDL/ExposedTo.cpp b/Libraries/LibIDL/ExposedTo.cpp index a39242812de..08e6f9baea4 100644 --- a/Libraries/LibIDL/ExposedTo.cpp +++ b/Libraries/LibIDL/ExposedTo.cpp @@ -38,7 +38,7 @@ ErrorOr parse_exposure_set(StringView interface_name, StringView expo return ExposedTo::ShadowRealm; if (exposed_trimmed[0] == '(') { - ExposedTo whom = Nobody; + ExposedTo whom = ExposedTo::Nobody; for (StringView candidate : exposed_trimmed.substring_view(1, exposed_trimmed.length() - 1).split_view(',')) { candidate = candidate.trim_whitespace(); if (candidate == "Window"sv) { diff --git a/Libraries/LibIDL/ExposedTo.h b/Libraries/LibIDL/ExposedTo.h index 15e9581f804..a04816a83ec 100644 --- a/Libraries/LibIDL/ExposedTo.h +++ b/Libraries/LibIDL/ExposedTo.h @@ -10,7 +10,7 @@ namespace IDL { -enum ExposedTo { +enum class ExposedTo { Nobody = 0x0, DedicatedWorker = 0x1, SharedWorker = 0x2, diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWindowOrWorkerInterfaces.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWindowOrWorkerInterfaces.cpp index 0cc7ea8784f..4cca490f365 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWindowOrWorkerInterfaces.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWindowOrWorkerInterfaces.cpp @@ -521,16 +521,16 @@ ErrorOr add_to_interface_sets(IDL::Interface& interface, InterfaceSets& in interface_sets.intrinsics.append(interface); - if (whom & IDL::ExposedTo::Window) + if (has_flag(whom, IDL::ExposedTo::Window)) interface_sets.window_exposed.append(interface); - if (whom & IDL::ExposedTo::DedicatedWorker) + if (has_flag(whom, IDL::ExposedTo::DedicatedWorker)) interface_sets.dedicated_worker_exposed.append(interface); - if (whom & IDL::ExposedTo::SharedWorker) + if (has_flag(whom, IDL::ExposedTo::SharedWorker)) interface_sets.shared_worker_exposed.append(interface); - if (whom & IDL::ExposedTo::ShadowRealm) + if (has_flag(whom, IDL::ExposedTo::ShadowRealm)) interface_sets.shadow_realm_exposed.append(interface); return {};