From 819f2c1df6791d41783f41885ca6044e24dd7800 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 21 Apr 2024 14:41:44 +0200 Subject: [PATCH] LibWeb: Don't redundantly re-sort StyleSheetList on sheet removal The list is already kept sorted. Removing one sheet anywhere from the list will not make it unsorted. --- Userland/Libraries/LibWeb/CSS/StyleSheetList.cpp | 10 ---------- Userland/Libraries/LibWeb/CSS/StyleSheetList.h | 2 -- 2 files changed, 12 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/StyleSheetList.cpp b/Userland/Libraries/LibWeb/CSS/StyleSheetList.cpp index 28e8f6b57a8..27192abe4c3 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleSheetList.cpp +++ b/Userland/Libraries/LibWeb/CSS/StyleSheetList.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include @@ -125,8 +124,6 @@ void StyleSheetList::remove_sheet(CSSStyleSheet& sheet) return; } - sort_sheets(); - m_document->style_computer().invalidate_rule_cache(); m_document->invalidate_style(); } @@ -176,11 +173,4 @@ WebIDL::ExceptionOr StyleSheetList::item_value(size_t index) const return m_sheets[index].ptr(); } -void StyleSheetList::sort_sheets() -{ - quick_sort(m_sheets, [](JS::NonnullGCPtr a, JS::NonnullGCPtr b) { - return a->owner_node()->is_before(*b->owner_node()); - }); -} - } diff --git a/Userland/Libraries/LibWeb/CSS/StyleSheetList.h b/Userland/Libraries/LibWeb/CSS/StyleSheetList.h index 61e2a179aeb..9ebe1238570 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleSheetList.h +++ b/Userland/Libraries/LibWeb/CSS/StyleSheetList.h @@ -50,8 +50,6 @@ private: void add_sheet(CSSStyleSheet&); void remove_sheet(CSSStyleSheet&); - void sort_sheets(); - JS::NonnullGCPtr m_document; Vector> m_sheets;