mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 19:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Avoid repetition when serializing grid track placement values

Browse source
This commit is contained in:
Tim Ledbetter 2025-03-18 15:00:44 +00:00 • committed by Alexander Kalenik
parent 7643a079c0
commit 83143e3018
Notes: github-actions[bot] 2025-03-19 01:09:09 +00:00
6 changed files with 22 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/CSS/GridTrackPlacement.cpp
View file

@ -22,8 +22,7 @@ String GridTrackPlacement::to_string() const
builder.appendff("{} {}", *area_or_line.line_number, *area_or_line.name);
} else if (area_or_line.line_number.has_value()) {
builder.appendff("{}", *area_or_line.line_number);
}
if (area_or_line.name.has_value()) {
} else if (area_or_line.name.has_value()) {
builder.appendff("{}", *area_or_line.name);
}
},

10
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-area-computed.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 30 tests
9 Pass
21 Fail
12 Pass
18 Fail
Fail Property grid-area value 'auto / auto / auto / auto'
Pass Property grid-row value 'auto / auto'
Pass Property grid-column-end value 'auto'
@ -13,12 +13,12 @@ Fail Property grid-column-start value '-_π'
Pass Property grid-row-end value '_9'
Fail Property grid-area value '1 / 90 -a- / auto / auto'
Fail Property grid-row value '2 az / auto'
Fail Property grid-column value '9 / -19 zA'
Pass Property grid-column value '9 / -19 zA'
Pass Property grid-row-start value '-19'
Fail Property grid-row-start value '9 -Z_'
Fail Property grid-column-start value '-44 Z'
Pass Property grid-column-start value '-44 Z'
Fail Property grid-row-end value '1 -πA'
Fail Property grid-column-end value '5 π_'
Pass Property grid-column-end value '5 π_'
Fail Property grid-area value 'span 2 i / auto / auto / auto'
Pass Property grid-row value 'span 2 / auto'
Fail Property grid-column-start value 'span 1 i'

8
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-area-shorthand.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 53 tests
42 Pass
11 Fail
44 Pass
9 Fail
Pass e.style['grid-area'] = "auto" should set grid-column-end
Pass e.style['grid-area'] = "auto" should set grid-column-start
Pass e.style['grid-area'] = "auto" should set grid-row-end
@ -45,8 +45,8 @@ Pass e.style['grid-row'] = "auto" should not set unrelated longhands
Pass e.style['grid-row'] = "one / 2" should set grid-row-end
Pass e.style['grid-row'] = "one / 2" should set grid-row-start
Pass e.style['grid-row'] = "one / 2" should not set unrelated longhands
Fail e.style['grid-row'] = "1 two / four 3" should set grid-row-end
Fail e.style['grid-row'] = "1 two / four 3" should set grid-row-start
Pass e.style['grid-row'] = "1 two / four 3" should set grid-row-end
Pass e.style['grid-row'] = "1 two / four 3" should set grid-row-start
Pass e.style['grid-row'] = "1 two / four 3" should not set unrelated longhands
Pass e.style['grid-column'] = "5 span" should set grid-column-end
Pass e.style['grid-column'] = "5 span" should set grid-column-start

8
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-area-valid.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 57 tests
13 Pass
44 Fail
15 Pass
42 Fail
Fail e.style['grid-area'] = "auto" should set the property value
Fail e.style['grid-area'] = "auto / auto" should set the property value
Fail e.style['grid-area'] = "auto / auto / auto" should set the property value
@ -28,9 +28,9 @@ Fail e.style['grid-column'] = "-A0 33" should set the property value
Pass e.style['grid-row-start'] = "-19" should set the property value
Fail e.style['grid-row-start'] = "9 -Z_" should set the property value
Pass e.style['grid-column-start'] = "+90" should set the property value
Fail e.style['grid-column-start'] = "Z -44" should set the property value
Pass e.style['grid-column-start'] = "Z -44" should set the property value
Fail e.style['grid-row-end'] = "1 -πA" should set the property value
Fail e.style['grid-column-end'] = "π_ +5" should set the property value
Pass e.style['grid-column-end'] = "π_ +5" should set the property value
Fail e.style['grid-area'] = "span 2 i" should set the property value
Fail e.style['grid-area'] = "i 2 SpAn" should set the property value
Fail e.style['grid-area'] = "span 1 i" should set the property value

8
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-column-shorthand.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 48 tests
36 Pass
12 Fail
38 Pass
10 Fail
Pass e.style['grid-column'] = "auto / auto" should set grid-column-end
Pass e.style['grid-column'] = "auto / auto" should set grid-column-start
Pass e.style['grid-column'] = "auto / auto" should not set unrelated longhands
@ -29,10 +29,10 @@ Pass e.style['grid-column'] = "span 2" should set grid-column-end
Pass e.style['grid-column'] = "span 2" should set grid-column-start
Pass e.style['grid-column'] = "span 2" should not set unrelated longhands
Pass e.style['grid-column'] = "3 last / auto" should set grid-column-end
Fail e.style['grid-column'] = "3 last / auto" should set grid-column-start
Pass e.style['grid-column'] = "3 last / auto" should set grid-column-start
Pass e.style['grid-column'] = "3 last / auto" should not set unrelated longhands
Fail e.style['grid-column'] = "3 last" should set grid-column-end
Fail e.style['grid-column'] = "3 last" should set grid-column-start
Pass e.style['grid-column'] = "3 last" should set grid-column-start
Pass e.style['grid-column'] = "3 last" should not set unrelated longhands
Fail e.style['grid-column'] = "span first / auto" should set grid-column-end
Fail e.style['grid-column'] = "span first / auto" should set grid-column-start

8
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-row-shorthand.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 48 tests
36 Pass
12 Fail
38 Pass
10 Fail
Pass e.style['grid-row'] = "auto / auto" should set grid-row-end
Pass e.style['grid-row'] = "auto / auto" should set grid-row-start
Pass e.style['grid-row'] = "auto / auto" should not set unrelated longhands
@ -29,10 +29,10 @@ Pass e.style['grid-row'] = "span 2" should set grid-row-end
Pass e.style['grid-row'] = "span 2" should set grid-row-start
Pass e.style['grid-row'] = "span 2" should not set unrelated longhands
Pass e.style['grid-row'] = "3 last / auto" should set grid-row-end
Fail e.style['grid-row'] = "3 last / auto" should set grid-row-start
Pass e.style['grid-row'] = "3 last / auto" should set grid-row-start
Pass e.style['grid-row'] = "3 last / auto" should not set unrelated longhands
Fail e.style['grid-row'] = "3 last" should set grid-row-end
Fail e.style['grid-row'] = "3 last" should set grid-row-start
Pass e.style['grid-row'] = "3 last" should set grid-row-start
Pass e.style['grid-row'] = "3 last" should not set unrelated longhands
Fail e.style['grid-row'] = "span first / auto" should set grid-row-end
Fail e.style['grid-row'] = "span first / auto" should set grid-row-start