mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-11 18:50:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS: Add a bunch of fast_is<T> helpers for commonly checked types

Browse source 
Based on what was hitting dynamic_cast<T> on Speedometer.
This commit is contained in:
Andreas Kling 2025-04-18 10:17:45 +02:00 • committed by Andreas Kling
commit 84626c7db2
Notes: github-actions[bot] 2025-04-18 12:48:02 +00:00
4 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Libraries/LibJS/AST.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2024, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2020-2025, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2020-2022, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2021-2022, David Tuin <davidot@serenityos.org>
*
@ -102,6 +102,11 @@ public:
virtual bool is_labelled_statement() const { return false; }
virtual bool is_iteration_statement() const { return false; }
virtual bool is_class_method() const { return false; }
virtual bool is_spread_expression() const { return false; }
virtual bool is_function_body() const { return false; }
virtual bool is_block_statement() const { return false; }
virtual bool is_primitive_literal() const { return false; }
virtual bool is_optional_chain() const { return false; }
protected:
explicit ASTNode(SourceRange);
@ -573,6 +578,9 @@ public:
: ScopeNode(move(source_range))
{
}
private:
virtual bool is_block_statement() const override { return true; }
};
class FunctionBody final : public ScopeNode {
@ -587,6 +595,8 @@ public:
bool in_strict_mode() const { return m_in_strict_mode; }
private:
virtual bool is_function_body() const override { return true; }
bool m_in_strict_mode { false };
};
@ -1191,6 +1201,9 @@ protected:
: Expression(move(source_range))
{
}
private:
virtual bool is_primitive_literal() const override { return true; }
};
class BooleanLiteral final : public PrimitiveLiteral {
@ -1533,6 +1546,8 @@ public:
virtual Bytecode::CodeGenerationErrorOr<Optional<Bytecode::ScopedOperand>> generate_bytecode(Bytecode::Generator&, Optional<Bytecode::ScopedOperand> preferred_dst = {}) const override;
private:
virtual bool is_spread_expression() const override { return true; }
NonnullRefPtr<Expression const> m_target;
};
@ -1995,6 +2010,8 @@ public:
Vector<Reference> const& references() const { return m_references; }
private:
virtual bool is_optional_chain() const override { return true; }
NonnullRefPtr<Expression const> m_base;
Vector<Reference> m_references;
};
@ -2288,4 +2305,19 @@ inline bool ASTNode::fast_is<IterationStatement>() const { return is_iteration_s
template<>
inline bool ASTNode::fast_is<ClassMethod>() const { return is_class_method(); }
template<>
inline bool ASTNode::fast_is<SpreadExpression>() const { return is_spread_expression(); }
template<>
inline bool ASTNode::fast_is<FunctionBody>() const { return is_function_body(); }
template<>
inline bool ASTNode::fast_is<BlockStatement>() const { return is_block_statement(); }
template<>
inline bool ASTNode::fast_is<PrimitiveLiteral>() const { return is_primitive_literal(); }
template<>
inline bool ASTNode::fast_is<OptionalChain>() const { return is_optional_chain(); }
}

3
Libraries/LibJS/Runtime/FunctionObject.h
View file

@ -50,4 +50,7 @@ private:
virtual bool is_function() const override { return true; }
};
template<>
inline bool Object::fast_is<FunctionObject>() const { return is_function(); }
}

1
Libraries/LibJS/Runtime/Object.h
View file

@ -191,6 +191,7 @@ public:
virtual bool is_dom_node() const { return false; }
virtual bool is_function() const { return false; }
virtual bool is_promise() const { return false; }
virtual bool is_error() const { return false; }
virtual bool is_date() const { return false; }
virtual bool is_number_object() const { return false; }

4
Libraries/LibJS/Runtime/Promise.h
View file

@ -54,6 +54,7 @@ protected:
virtual void visit_edges(Visitor&) override;
private:
virtual bool is_promise() const override { return true; }
bool is_settled() const { return m_state == State::Fulfilled || m_state == State::Rejected; }
void trigger_reactions() const;
@ -66,4 +67,7 @@ private:
bool m_is_handled { false }; // [[PromiseIsHandled]]
};
template<>
inline bool Object::fast_is<Promise>() const { return is_promise(); }
}