From 848a250b29f4581eb2ce486109d0697137d05a42 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 9 Apr 2025 16:36:07 +0100 Subject: [PATCH] LibWeb/CSS: Mark CSSImportRule.media as nullable See the linked spec issue for more details. The MediaList can be null internally, and this was upsetting GCC as it meant our bindings code was dereferencing a null pointer. --- Libraries/LibWeb/CSS/CSSImportRule.idl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/CSS/CSSImportRule.idl b/Libraries/LibWeb/CSS/CSSImportRule.idl index 2256427abd2..c16a272a42b 100644 --- a/Libraries/LibWeb/CSS/CSSImportRule.idl +++ b/Libraries/LibWeb/CSS/CSSImportRule.idl @@ -6,7 +6,8 @@ [Exposed=Window] interface CSSImportRule : CSSRule { readonly attribute USVString href; - [SameObject, PutForwards=mediaText] readonly attribute MediaList media; + // AD-HOC: media is null if styleSheet is null. Spec issue: https://github.com/w3c/csswg-drafts/issues/12063 + [SameObject, PutForwards=mediaText] readonly attribute MediaList? media; [SameObject, ImplementedAs=style_sheet_for_bindings] readonly attribute CSSStyleSheet? styleSheet; [FIXME] readonly attribute CSSOMString? layerName; readonly attribute CSSOMString? supportsText;