mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWebView: Rename a couple of console-related callbacks for clarity

Browse source 
The "on_received_console_message" and "on_received_console_messages"
were indistinguishable in purpose based on their name. This renames them
to:

on_console_message_available - WebContent has output a console message
and it is available for the client to retrieve.

on_received_styled_console_messages - WebContent has replied to a
request for the available console messages.

The "styled" qualifier is used here to indicate that the messages have
been styled with CSS for display in a WebView. This is to prepare for
an upcoming patch where DevToolsConsoleClient will not stylize the
output; DevTools will want the raw JS values.
This commit is contained in:
Timothy Flynn 2025-03-04 07:56:42 -05:00 • committed by Tim Flynn
commit 848ac11495
Notes: github-actions[bot] 2025-03-04 20:34:57 +00:00
9 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWebView/InspectorClient.h
View file

@ -57,8 +57,8 @@ private:
void load_cookies();
void request_console_messages();
void handle_console_message(i32 message_index);
void handle_console_messages(i32 start_index, ReadonlySpan<String> message_types, ReadonlySpan<String> messages);
void console_message_available(i32 message_index);
void console_messages_received(i32 start_index, ReadonlySpan<String> message_types, ReadonlySpan<String> messages);
void append_console_source(StringView);
void append_console_message(StringView);