mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 13:19:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWebView: Rename a couple of console-related callbacks for clarity

Browse source 
The "on_received_console_message" and "on_received_console_messages"
were indistinguishable in purpose based on their name. This renames them
to:

on_console_message_available - WebContent has output a console message
and it is available for the client to retrieve.

on_received_styled_console_messages - WebContent has replied to a
request for the available console messages.

The "styled" qualifier is used here to indicate that the messages have
been styled with CSS for display in a WebView. This is to prepare for
an upcoming patch where DevToolsConsoleClient will not stylize the
output; DevTools will want the raw JS values.
This commit is contained in:
Timothy Flynn 2025-03-04 07:56:42 -05:00 • committed by Tim Flynn
commit 848ac11495
Notes: github-actions[bot] 2025-03-04 20:34:57 +00:00
9 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Services/WebContent/PageClient.cpp
View file

@ -805,9 +805,9 @@ void PageClient::console_peer_did_misbehave(char const* reason)
client().did_misbehave(reason);
}
void PageClient::did_get_js_console_messages(i32 start_index, Vector<String> message_types, Vector<String> messages)
void PageClient::did_get_styled_js_console_messages(i32 start_index, Vector<String> message_types, Vector<String> messages)
{
client().async_did_get_js_console_messages(m_id, start_index, move(message_types), move(messages));
client().async_did_get_styled_js_console_messages(m_id, start_index, move(message_types), move(messages));
}
static void gather_style_sheets(Vector<Web::CSS::StyleSheetIdentifier>& results, Web::CSS::CSSStyleSheet& sheet)