mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-24 11:21:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Handle continuation chain during hit-testing instead of after it

Browse source 
My previous attempt at resolving the continuation chain tried to deal
with `pointer-events: none` by repeatedly falling back to the parent
paintable until one was found that _would_ want to handle pointer
events. But since we were no longer performing hit-tests on those
paintables, false positives could pop up. This could happen for
out-of-flow block elements that did not overlap with their parent rects,
for example.

This approach works much better since it only handles the continuation
case that's relevant (the "middle" anonymous box) and it does so during
hit-testing instead of after, allowing all the other relevant logic to
come into play.
This commit is contained in:
Jelle Raaijmakers 2025-01-26 00:35:59 +01:00 • committed by Alexander Kalenik
commit 84c4702b10
Notes: github-actions[bot] 2025-01-26 16:30:51 +00:00
4 changed files with 45 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/Painting/PaintableBox.h
View file

@ -144,6 +144,7 @@ public:
[[nodiscard]] virtual TraversalDecision hit_test(CSSPixelPoint position, HitTestType type, Function<TraversalDecision(HitTestResult)> const& callback) const override;
Optional<HitTestResult> hit_test(CSSPixelPoint, HitTestType) const;
[[nodiscard]] TraversalDecision hit_test_continuation(Function<TraversalDecision(HitTestResult)> const& callback) const;
virtual bool handle_mousewheel(Badge<EventHandler>, CSSPixelPoint, unsigned buttons, unsigned modifiers, int wheel_delta_x, int wheel_delta_y) override;