mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Limit sibling style invalidation by max distance

Browse source 
If an element is affected only by selectors using the direct sibling
combinator `+`, we can calculate the maximum invalidation distance and
use it to limit style invalidation. For example, the selector
`.a + .b + .c` has a maximum invalidation distance of 2, meaning we can
skip invalidating any element affected by this selector if it's more
than two siblings away from the element that triggered the style
invalidation.

This change results in visible performance improvement when hovering
PR list on GitHub.
This commit is contained in:
Aliaksandr Kalenik 2025-03-10 16:16:08 +01:00 • committed by Alexander Kalenik
commit 84ecaaa75c
Notes: github-actions[bot] 2025-03-10 17:57:49 +00:00
6 changed files with 61 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibWeb/DOM/Element.h
View file

@ -437,8 +437,11 @@ public:
bool affected_by_has_pseudo_class_with_relative_selector_that_has_sibling_combinator() const { return m_affected_by_has_pseudo_class_with_relative_selector_that_has_sibling_combinator; }
void set_affected_by_has_pseudo_class_with_relative_selector_that_has_sibling_combinator(bool value) { m_affected_by_has_pseudo_class_with_relative_selector_that_has_sibling_combinator = value; }
bool affected_by_sibling_combinator() const { return m_affected_by_sibling_combinator; }
void set_affected_by_sibling_combinator(bool value) { m_affected_by_sibling_combinator = value; }
bool affected_by_direct_sibling_combinator() const { return m_affected_by_direct_sibling_combinator; }
void set_affected_by_direct_sibling_combinator(bool value) { m_affected_by_direct_sibling_combinator = value; }
bool affected_by_indirect_sibling_combinator() const { return m_affected_by_indirect_sibling_combinator; }
void set_affected_by_indirect_sibling_combinator(bool value) { m_affected_by_indirect_sibling_combinator = value; }
bool affected_by_first_or_last_child_pseudo_class() const { return m_affected_by_first_or_last_child_pseudo_class; }
void set_affected_by_first_or_last_child_pseudo_class(bool value) { m_affected_by_first_or_last_child_pseudo_class = value; }
@ -446,9 +449,12 @@ public:
bool affected_by_nth_child_pseudo_class() const { return m_affected_by_nth_child_pseudo_class; }
void set_affected_by_nth_child_pseudo_class(bool value) { m_affected_by_nth_child_pseudo_class = value; }
size_t sibling_invalidation_distance() const { return m_sibling_invalidation_distance; }
void set_sibling_invalidation_distance(size_t value) { m_sibling_invalidation_distance = value; }
bool style_affected_by_structural_changes() const
{
return affected_by_sibling_combinator() || affected_by_first_or_last_child_pseudo_class() || affected_by_nth_child_pseudo_class();
return affected_by_direct_sibling_combinator() || affected_by_indirect_sibling_combinator() || affected_by_first_or_last_child_pseudo_class() || affected_by_nth_child_pseudo_class();
}
size_t number_of_owned_list_items() const;
@ -547,11 +553,14 @@ private:
bool m_style_uses_css_custom_properties { false };
bool m_affected_by_has_pseudo_class_in_subject_position : 1 { false };
bool m_affected_by_has_pseudo_class_in_non_subject_position : 1 { false };
bool m_affected_by_sibling_combinator : 1 { false };
bool m_affected_by_direct_sibling_combinator : 1 { false };
bool m_affected_by_indirect_sibling_combinator : 1 { false };
bool m_affected_by_first_or_last_child_pseudo_class : 1 { false };
bool m_affected_by_nth_child_pseudo_class : 1 { false };
bool m_affected_by_has_pseudo_class_with_relative_selector_that_has_sibling_combinator : 1 { false };
size_t m_sibling_invalidation_distance { 0 };
OwnPtr<CSS::CountersSet> m_counters_set;
GC::Ptr<DOM::Element> m_aria_active_descendant_element;