mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Parse an ident in :dir(), not a keyword

Browse source 
The spec requires us to accept any ident here, not just ltr/rtl, and
also serialize it back out. That means we need to keep the original
string around.

In order to not call keyword_from_string() every time we want to match
a :dir() selector, we still attempt to parse the keyword and keep it
around.

A small behaviour change is that now we'll serialize the ident with its
original casing, instead of always lowercase. Chrome and Firefox
disagree on this, so I think either is fine until that can be
officially decided.

Gets us 2 WPT passes (including 1 from the as-yet-unmerged :dir() test).
This commit is contained in:
Sam Atkins 2025-05-16 14:57:18 +01:00 • committed by Andreas Kling
commit 8536e23674
Notes: github-actions[bot] 2025-05-16 22:31:53 +00:00
7 changed files with 25 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Dump.cpp
View file

@ -582,7 +582,7 @@ void dump_selector(StringBuilder& builder, CSS::Selector const& selector, int in
break;
}
case CSS::PseudoClassMetadata::ParameterType::Ident:
builder.appendff("(keyword={})", string_from_keyword(pseudo_class.keyword.value()));
builder.appendff("(ident={})", pseudo_class.ident->string_value);
break;
case CSS::PseudoClassMetadata::ParameterType::LanguageRanges: {
builder.append('(');