From 8588008d428cbccd14319ffcca449c60b025627e Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 25 Apr 2024 07:18:31 -0400 Subject: [PATCH] Ladybird: Use RequestServer for networking by default This really only affects headless-browser when it is linked with Qt. In that case, it currently uses Qt networking by default and does not have a flag to use RequestServer instead. Change the default to use RS so it can undergo sanitized testing in CI. --- Ladybird/AppKit/main.mm | 1 - Ladybird/Types.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Ladybird/AppKit/main.mm b/Ladybird/AppKit/main.mm index 0fc27b48a84..0f6a42b71fd 100644 --- a/Ladybird/AppKit/main.mm +++ b/Ladybird/AppKit/main.mm @@ -91,7 +91,6 @@ ErrorOr serenity_main(Main::Arguments arguments) .command_line = MUST(command_line_builder.to_string()), .executable_path = MUST(String::from_byte_string(MUST(Core::System::current_executable_path()))), .enable_gpu_painting = use_gpu_painting ? Ladybird::EnableGPUPainting::Yes : Ladybird::EnableGPUPainting::No, - .use_lagom_networking = Ladybird::UseLagomNetworking::Yes, .wait_for_debugger = debug_web_content ? Ladybird::WaitForDebugger::Yes : Ladybird::WaitForDebugger::No, .log_all_js_exceptions = log_all_js_exceptions ? Ladybird::LogAllJSExceptions::Yes : Ladybird::LogAllJSExceptions::No, }; diff --git a/Ladybird/Types.h b/Ladybird/Types.h index db42ea73c58..46a4e425cb4 100644 --- a/Ladybird/Types.h +++ b/Ladybird/Types.h @@ -56,7 +56,7 @@ struct WebContentOptions { EnableCallgrindProfiling enable_callgrind_profiling { EnableCallgrindProfiling::No }; EnableGPUPainting enable_gpu_painting { EnableGPUPainting::No }; IsLayoutTestMode is_layout_test_mode { IsLayoutTestMode::No }; - UseLagomNetworking use_lagom_networking { UseLagomNetworking::No }; + UseLagomNetworking use_lagom_networking { UseLagomNetworking::Yes }; WaitForDebugger wait_for_debugger { WaitForDebugger::No }; LogAllJSExceptions log_all_js_exceptions { LogAllJSExceptions::No }; EnableIDLTracing enable_idl_tracing { EnableIDLTracing::No };