mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-19 16:59:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Hide audio element when controls is not set

Browse source 
When an audio element has no controls attribute,
it should not render at all and take up no space.
This commit is contained in:
Psychpsyo 2025-01-04 12:13:40 +01:00 • committed by Sam Atkins
commit 8632ce5cdd
Notes: github-actions[bot] 2025-01-04 11:48:09 +00:00
5 changed files with 45 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibWeb/Layout/AudioBox.cpp
View file

@ -34,4 +34,21 @@ GC::Ptr<Painting::Paintable> AudioBox::create_paintable() const
return Painting::AudioPaintable::create(*this);
}
bool AudioBox::should_paint() const
{
auto const& audio_element = dom_node();
return audio_element.has_attribute(HTML::AttributeNames::controls) || audio_element.is_scripting_disabled();
}
void AudioBox::prepare_for_replaced_layout()
{
if (should_paint()) {
set_natural_width(300);
set_natural_height(40);
} else {
set_natural_width(0);
set_natural_height(0);
}
}
}