mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 05:39:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK+Everywhere: Prepare Utf16View for integration with a UTF-16 string

Browse source 
To prepare for an upcoming Utf16String, this migrates Utf16View to store
its data as a char16_t. Most function definitions are moved inline and
made constexpr.

This also adds a UDL to construct a Utf16View from a string literal:

    auto string = u"hello"sv;

This let's us remove the NTTP Utf16View constructor, as we have found
that such constructors bloat binary size quite a bit.
This commit is contained in:
Timothy Flynn 2025-06-26 12:52:23 -04:00 • committed by Tim Flynn
commit 86b1c78c1a
Notes: github-actions[bot] 2025-07-03 13:53:23 +00:00
17 changed files with 406 additions and 421 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/DOM/CharacterData.cpp
View file

@ -86,11 +86,12 @@ WebIDL::ExceptionOr<void> CharacterData::replace_data(size_t offset, size_t coun
auto before_data = utf16_view.substring_view(0, offset);
auto inserted_data_result = MUST(AK::utf8_to_utf16(data));
auto after_data = utf16_view.substring_view(offset + count);
Utf16Data full_data;
full_data.ensure_capacity(before_data.length_in_code_units() + inserted_data_result.data.size() + after_data.length_in_code_units());
full_data.append(before_data.data(), before_data.length_in_code_units());
full_data.append(before_data.span().data(), before_data.length_in_code_units());
full_data.extend(inserted_data_result.data);
full_data.append(after_data.data(), after_data.length_in_code_units());
full_data.append(after_data.span().data(), after_data.length_in_code_units());
Utf16View full_view { full_data };
bool characters_are_the_same = utf16_view == full_view;