mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-31 07:22:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS: Evaluate NewExpression arguments before checking constructor type

Browse source 
Exactly like in 99f9609, which fixed the same issue in CallExpression,
the spec tells us to *first* evaluate the arguments, if any, and *then*
check if the provided value is a constructor function.
This commit is contained in:
Linus Groh 2021-12-30 01:01:28 +01:00
parent d636f7703d
commit 87068896d0
Notes: sideshowbarker 2024-07-18 02:13:10 +09:00
2 changed files with 74 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

81
Userland/Libraries/LibJS/Tests/functions/function-evaluation-order.js
View file

@ -1,30 +1,65 @@
test("callee is evaluated before arguments", () => {
function foo() {}
const values = [];
describe("CallExpression", () => {
test("callee is evaluated before arguments", () => {
function foo() {}
const values = [];
[foo][(values.push("callee"), 0)](values.push("args"));
[foo][(values.push("callee"), 0)](values.push("args"));
expect(values).toEqual(["callee", "args"]);
expect(values).toEqual(["callee", "args"]);
});
test("arguments are evaluated in order", () => {
function foo() {}
const values = [];
foo(values.push("arg1"), values.push("arg2"), values.push("arg3"));
expect(values).toEqual(["arg1", "arg2", "arg3"]);
});
test("arguments are evaluated before callee is checked for its type", () => {
const values = [];
expect(() => {
"foo"(values.push("args"));
}).toThrowWithMessage(TypeError, "foo is not a function");
expect(values).toEqual(["args"]);
expect(() => {
"foo"(bar);
}).toThrowWithMessage(ReferenceError, "'bar' is not defined");
});
});
test("arguments are evaluated in order", () => {
function foo() {}
const values = [];
describe("NewExpression", () => {
test("callee is evaluated before arguments", () => {
function Foo() {}
const values = [];
foo(values.push("arg1"), values.push("arg2"), values.push("arg3"));
new [Foo][(values.push("callee"), 0)](values.push("args"));
expect(values).toEqual(["arg1", "arg2", "arg3"]);
});
test("arguments are evaluated before callee is checked for its type", () => {
const values = [];
expect(() => {
"foo"(values.push("args"));
}).toThrowWithMessage(TypeError, "foo is not a function");
expect(values).toEqual(["args"]);
expect(() => {
"foo"(bar);
}).toThrowWithMessage(ReferenceError, "'bar' is not defined");
expect(values).toEqual(["callee", "args"]);
});
test("arguments are evaluated in order", () => {
function Foo() {}
const values = [];
new Foo(values.push("arg1"), values.push("arg2"), values.push("arg3"));
expect(values).toEqual(["arg1", "arg2", "arg3"]);
});
test("arguments are evaluated before callee is checked for its type", () => {
const values = [];
expect(() => {
new "Foo"(values.push("args"));
}).toThrowWithMessage(TypeError, "Foo is not a constructor");
expect(values).toEqual(["args"]);
expect(() => {
new "Foo"(bar);
}).toThrowWithMessage(ReferenceError, "'bar' is not defined");
});
});