mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 21:59:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't store Page on ResourceLoader

Browse source 
We only need a Page for file:// urls. At some point we probably
needed it for other kinds of requests, but the current functionality
doesn't need to store the Page pointer on the ResourceLoader.
This commit is contained in:
Andrew Kaster 2025-01-15 15:06:39 -07:00 • committed by Andrew Kaster
commit 8760825bb4
Notes: github-actions[bot] 2025-02-18 18:37:01 +00:00
4 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/Loader/ResourceLoader.cpp
View file

@ -334,11 +334,9 @@ void ResourceLoader::load(LoadRequest& request, GC::Root<SuccessCallback> succes
}
if (url.scheme() == "file") {
if (request.page())
m_page = request.page();
if (!m_page.has_value()) {
log_failure(request, "INTERNAL ERROR: No Page for request");
auto page = request.page();
if (!page) {
log_failure(request, "INTERNAL ERROR: No Page for file scheme request");
return;
}
@ -396,7 +394,7 @@ void ResourceLoader::load(LoadRequest& request, GC::Root<SuccessCallback> succes
success_callback->function()(data, response_headers, {}, {});
});
(*m_page)->client().request_file(move(file_request));
page->client().request_file(move(file_request));
++m_pending_loads;
if (on_load_counter_change)