From 876d26c32e48cb246b9dabdb2f01cc5d7133002f Mon Sep 17 00:00:00 2001 From: Luke Wilde Date: Wed, 8 Jan 2025 13:14:19 +0000 Subject: [PATCH] LibWeb/WebGL: Respect subarrays in readPixels --- .../LibWeb/GenerateWebGLRenderingContext.cpp | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp index 1839751e185..fd4b0b6ffb7 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp @@ -1036,17 +1036,7 @@ public: return; } - void *ptr = nullptr; - if (pixels->is_data_view()) { - auto& data_view = static_cast(*pixels->raw_object()); - ptr = data_view.viewed_array_buffer()->buffer().data(); - } else if (pixels->is_typed_array_base()) { - auto& typed_array_base = static_cast(*pixels->raw_object()); - ptr = typed_array_base.viewed_array_buffer()->buffer().data(); - } else { - VERIFY_NOT_REACHED(); - } - + void *ptr = pixels->viewed_array_buffer()->buffer().data() + pixels->byte_offset(); glReadPixels(x, y, width, height, format, type, ptr); )~~~"); continue;