mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-02 06:09:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use 0 as min-content size for items with overflow:hidden [GFC]
Some checks are pending
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
This behavior is not specified but required to match other browsers.

Fixes https://github.com/LadybirdBrowser/ladybird/issues/5907
This commit is contained in:
Aliaksandr Kalenik 2025-08-30 15:32:43 +02:00 • committed by Jelle Raaijmakers
commit 87c7fb1d63
Notes: github-actions[bot] 2025-08-30 13:58:56 +00:00
3 changed files with 44 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -2460,7 +2460,14 @@ CSSPixels GridFormattingContext::calculate_min_content_contribution(GridItem con
} }
if (should_treat_preferred_size_as_auto) { if (should_treat_preferred_size_as_auto) {
auto result = item.add_margin_box_sizes(calculate_min_content_size(item, dimension), dimension); CSSPixels min_content_size;
// NOTE: This behavior is not defined in the spec, but seems required to match other browsers.
if (item.box->is_scroll_container()) {
min_content_size = 0;
} else {
min_content_size = calculate_min_content_size(item, dimension);
}
auto result = item.add_margin_box_sizes(min_content_size, dimension);
return min(result, maximum_size); return min(result, maximum_size);
} }

20
Tests/LibWeb/Layout/expected/grid/inline-item-with-overflow-hidden.txt Normal file
View file

@ -0,0 +1,20 @@
Viewport <#document> at [0,0] [0+0+0 800 0+0+0] [0+0+0 600 0+0+0] children: not-inline
BlockContainer <html> at [0,0] [0+0+0 800 0+0+0] [0+0+0 34 0+0+0] [BFC] children: not-inline
BlockContainer <body> at [8,8] [8+0+0 784 0+0+8] [8+0+0 18 0+0+8] children: not-inline
Box <div.a> at [8,8] [0+0+0 784 0+0+0] [0+0+0 18 0+0+0] [GFC] children: not-inline
Box <div.b> at [8,8] [0+0+0 196 0+0+0] [0+0+0 18 0+0+0] [GFC] children: not-inline
BlockContainer <span> at [8,8] [0+0+0 196 0+0+0] [0+0+0 18 0+0+0] [BFC] children: inline
frag 0 from TextNode start: 0, length: 115, rect: [8,8 970.5625x18] baseline: 13.796875
"Very very very long sentence lorem ipsum too long to fit what will happen with this sentence? Nobody knows for sure"
TextNode <#text> (not painted)
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x34]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x18]
PaintableBox (Box<DIV>.a) [8,8 784x18]
PaintableBox (Box<DIV>.b) [8,8 196x18]
PaintableWithLines (BlockContainer<SPAN>) [8,8 196x18] overflow: [8,8 970.5625x18]
TextPaintable (TextNode<#text>)
SC for Viewport<#document> [0,0 800x600] [children: 1] (z-index: auto)
SC for BlockContainer<HTML> [0,0 800x34] [children: 0] (z-index: auto)

16
Tests/LibWeb/Layout/input/grid/inline-item-with-overflow-hidden.html Normal file
View file

@ -0,0 +1,16 @@
<!DOCTYPE html>
<style>
.a {
display: grid;
grid-template-columns: repeat(4, 1fr);
}
.b {
background-color: #5f5;
display: grid;
}
span {
overflow: hidden;
white-space: nowrap;
}
</style>
<div class="a"><div class="b"><span>Very very very long sentence lorem ipsum too long to fit what will happen with this sentence? Nobody knows for sure