From 87c8ae31d3f6a4f21673494b2b50e8b0280eae4e Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Sun, 1 Dec 2024 22:56:27 +1300 Subject: [PATCH] LibURL: Set IDNA's IgnoreInvalidPunycode to false See: https://github.com/whatwg/url/commit/a6e449 - which should have no functional change. --- Libraries/LibURL/Parser.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Libraries/LibURL/Parser.cpp b/Libraries/LibURL/Parser.cpp index 7fb7fcdb6d1..1e4794e5601 100644 --- a/Libraries/LibURL/Parser.cpp +++ b/Libraries/LibURL/Parser.cpp @@ -506,7 +506,8 @@ static ErrorOr domain_to_ascii(StringView domain, bool be_strict) // CheckJoiners set to true, // UseSTD3ASCIIRules set to beStrict, // Transitional_Processing set to false, - // VerifyDnsLength set to beStrict. [UTS46]. + // VerifyDnsLength set to beStrict, + // and IgnoreInvalidPunycode set to false. [UTS46] // 2. If result is a failure value, domain-to-ASCII validation error, return failure. @@ -538,7 +539,8 @@ static ErrorOr domain_to_ascii(StringView domain, bool be_strict) Unicode::IDNA::CheckJoiners::Yes, be_strict ? Unicode::IDNA::UseStd3AsciiRules::Yes : Unicode::IDNA::UseStd3AsciiRules::No, Unicode::IDNA::TransitionalProcessing::No, - be_strict ? Unicode::IDNA::VerifyDnsLength::Yes : Unicode::IDNA::VerifyDnsLength::No + be_strict ? Unicode::IDNA::VerifyDnsLength::Yes : Unicode::IDNA::VerifyDnsLength::No, + Unicode::IDNA::IgnoreInvalidPunycode::No, }; auto result = TRY(Unicode::IDNA::to_ascii(Utf8View(domain), options));